feat: changing codepage - #104
Merged
Merged
Conversation
taizod1024
marked this pull request as draft
June 1, 2024 00:36
taizod1024
marked this pull request as ready for review
June 1, 2024 00:36
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for overriding the WinRM shell codepage via the RD_NODE_CODEPAGE environment variable, aligning behavior with the existing RD_NODE_OUTPUT_CHARSET override pattern used elsewhere in the plugin.
Changes:
- Introduce a default codepage (65001) and allow override from
RD_NODE_CODEPAGE. - Pass the selected
codepagevalue intoself.protocol.open_shell(...)instead of a hardcoded literal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Parse the env var as int with a trim, falling back to the default and logging a warning on invalid input, instead of passing the raw string through to open_shell(). Also hoists DEFAULT_CODEPAGE out of run_cmd so it isn't shadowed as a function-local pseudo-constant.
fdevans
approved these changes
Aug 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the environment variable RD_NODE_CODEPAGE is set, change the codepage.
The implementation method is the same as the RD_NODE_OUTPUT_CHARSET of winrm_exec.py.
seealso: #103 (comment)
file: py-winrm-plugin-2.1.3+104.zip
Maintainer notes:
maininto this branch (was 59 commits behind) to bring it up to date.RD_NODE_CODEPAGE: value is trimmed and parsed as an int, falling back to the default codepage with a warning logged on invalid input, instead of passing the raw string straight intoopen_shell(). Also movedDEFAULT_CODEPAGEto a module-level constant../gradlew buildpasses, the packaged zip contains the updated code, and the full Python unit test suite (26 tests) passes.