Repository navigation
Conversation
pcanal
reviewed
Oct 27, 2026
pcanal
approved these changes
Oct 27, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
LGTM (We should consider implementing the move constructor or document why not).
And with that, fix the postfix increment operator of RNTupleProcessor::RIterator.
enirolf
force-pushed
the
ntuple-proc-iterator-copy
branch
from
October 27, 2026 16:31
38c954c to
d089140
Compare
vepadulano
approved these changes
Oct 27, 2026
Test Results 24 files 24 suites 3d 22h 17m 41s ⏱️ For more details on these failures, see this check. Results for commit d089140. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the requirement that the iterator of RNTupleProcessor::RIterator (which is an RNTupleProcessor::REntryMapping) must be copyable and fixes its postfix increment operator, as pointed out by @hahnjo in #23589.