Skip to content

[rfile] Further cleanups + allow setting object titles - #23811

Open
silverweed wants to merge 7 commits into
root-project:masterfrom
silverweed:rfile_cleanups3
Open

silverweed wants to merge 7 commits into
root-project:masterfrom
silverweed:rfile_cleanups3

Conversation

@silverweed

Copy link
Copy Markdown
Contributor

This Pull request:

Is the same as #23807 but without the TNamed-specific changes (will be a separate PR)
Adds some changes+fixes to RFile.

Changes or fixes:

  • allow setting objects' titles through Put
  • Replaced bool arg of Overwrite with bitmask for improved readability/expandability
  • Pythonized Overwrite so you can use keyword args instead of the bitmask
  • added tests
  • fixed bug in pythonized Get which didn't consider the cycle when getting the object.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions

Copy link
Copy Markdown

Test Results

    24 files      24 suites   3d 21h 30m 38s ⏱️
 3 893 tests  3 890 ✅ 0 💤 3 ❌
83 374 runs  83 371 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 0ec2fad.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants