Repository navigation
[rfile] Further cleanups + allow setting object titles - #23807
Closed
silverweed wants to merge 8 commits into
Closed
silverweed wants to merge 8 commits into
silverweed wants to merge 8 commits into
Conversation
Then call it from the current WriteObjectAny
silverweed
requested review from
guitargeek,
jblomer,
siliataider and
vepadulano
as code owners
October 23, 2026 08:17
silverweed
changed the title
vepadulano
reviewed
Oct 23, 2026
This will automatically call Put(obj.GetName(), obj, obj.GetTitle()). Added a pythonization as well.
silverweed
force-pushed
the
rfile_cleanups2
branch
from
October 23, 2026 09:41
3f34db4 to
ffd7a27
Compare
2 tasks done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds some changes and fixed for RFile.
Changes or fixes:
Put(const TNamed&)as suggested by Philippe (this replaces the alternative Put overload for the title). No overload of Overwrite yet because it's not so obvious how to introduce it cleanly.Overwritewith bitmask for improved readability/expandabilityChecklist: