Repository navigation
[gui] fix context menu for member with multiple toggles choise - #23782
Merged
Merged
Conversation
linev
added
in:Core Libraries
in:GUI
clean build
bellenot
reviewed
Oct 21, 2026
bellenot
left a comment
bellenot
left a comment
Member
There was a problem hiding this comment.
I confirm it works, for what concerns the GUI part. For what concerns meta, I'll let the other reviewers decide
linev
commented
Oct 21, 2026
linev
commented
Oct 21, 2026
Test Results 24 files 24 suites 4d 4h 7m 27s ⏱️ For more details on these failures, see this check. Results for commit 8a4746c. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Oct 21, 2026
pcanal
reviewed
Oct 21, 2026
Member
|
Sorry ... I inadvertently hit "close with comment" rather than "cancel comment" |
Member
This is because those need to be recalculated if the actual object's type is of a derived class. |
pcanal
reviewed
Oct 21, 2026
pcanal
reviewed
Oct 21, 2026
If data member is enum, setter method may accept enum data type and therefore TMethodCall(class,method_name,"1") is not working. One have to cast integer value to the type of setter method argument. Do it only for enum, for other types more complex condition may apply
When `TDataMember::GetterMethod()` or `TDataMember::SetterMethod()` are used to request `TMethodCall` instance - such instance is transient object and pointer cannot be preserved for a long time. Therefore in `TTogle` extract getter and setter callers right before usage. Solves crash in `TASImage`` context menu where `fImageQuality` member uses multiple toggles for selection of attribute. Also cleanup `TToggle` code to avoid plain string usage and simplify several methods.
Directly specify TDataMember pointer in SetToggledObject call. It has special handling in toggle object, therefore better use clear syntax here
Directly specify TDataMember pointer in SetToggledObject call. It has special handling in toggle object, therefore better use clear syntax here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
fImageQualityof the TASImage - see for instance galaxy_image.C tutorial.ROOT crashes when trying to select not the last value in the submenu.
Problem that
TToggleobject rememeber pointers on setter and getter whichthen used to select one of the values. But such setter/getter are transient objects
which are deleted by next call to TDataMember::GetterMethod() / TDataMember::SetterMethod()
Therefore in
TTogleextract getter and setter callers right before usage. Also cleanupTTogglecode to avoid plain string usage and simplifyseveral methods.
Also fix TDataMember::SetterMethod() - when as method argument
enumis used.In such case one has to cast argument to actual data type - otherwise TMethodCall is not working.
Cleanup cde in TRootCanvas and TQt6Canvas where correspondent TToggle instances are created