Repository navigation
[6.40] [gui] fix context menu for member with multiple toggles choise - #23841
Merged
Merged
Conversation
If data member is enum, setter method may accept enum data type and therefore TMethodCall(class,method_name,"1") is not working. One have to cast integer value to the type of setter method argument. Do it only for enum, for other types more complex condition may apply
When `TDataMember::GetterMethod()` or `TDataMember::SetterMethod()` are used to request `TMethodCall` instance - such instance is transient object and pointer cannot be preserved for a long time. Therefore in `TTogle` extract getter and setter callers right before usage. Solves crash in `TASImage`` context menu where `fImageQuality` member uses multiple toggles for selection of attribute. Also cleanup `TToggle` code to avoid plain string usage and simplify several methods.
Directly specify TDataMember pointer in SetToggledObject call. It has special handling in toggle object, therefore better use clear syntax here
Test Results 22 files 22 suites 3d 13h 22m 2s ⏱️ For more details on these failures, see this check. Results for commit 474a1e3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23782