[2/2] Add callback type attribute used by async methods#725
Open
Akarinnnnn wants to merge 3 commits intorlabrecque:masterfrom
Open
[2/2] Add callback type attribute used by async methods#725Akarinnnnn wants to merge 3 commits intorlabrecque:masterfrom
Akarinnnnn wants to merge 3 commits intorlabrecque:masterfrom
Conversation
After this change, inteface gen should run before struct gen. This is mentioned in CodeGen entrypoint to avoid accidently reordered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #724, split out from #720. Add callback annotations attributes used by async steam methods. Notice: this change does not involve generated file. Should use another commit to update these generated files.
I plan to add generic constraint to
Callback<T>andCallResult<T>, to avoid misuses likeCallback<StructFromCallResult_t>. They will look likeCallback<T> where T : ICallbackStructandCallResult<T> where T : ICallResultStruct. Generated structs which comes from callback dispatch system will implement one of these marker interface.