Annotate callback or call-result types to async interface methods.#720
Closed
Akarinnnnn wants to merge 1 commit intorlabrecque:masterfrom
Closed
Annotate callback or call-result types to async interface methods.#720Akarinnnnn wants to merge 1 commit intorlabrecque:masterfrom
Akarinnnnn wants to merge 1 commit intorlabrecque:masterfrom
Conversation
This was referenced Jul 15, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems caused by misuse callback or call-result has been a FAQ to our library. This pr: annotating callback or call-result types to async interface methods is helpful for developers to view which type to use. Another aspect is there attributes is essential for static analyzers to analyze is their usage correct.
The next step is, write a Roslyn analyzer Steamworks.Net.Analyzers. This static analyzer is applicable to projects uses Roslyn compiler. For example, project referenced analyzer NuGet package. If my remember is correct, Unity also uses Roslyn compiler after MonoBleedingEdge. This means Unity is potentially benefited to by editing some compiler flags or place analyzer DLL into a directory.