Stop setting the deploying stage of a run - #38
Merged
Merged
Conversation
prompt-to-app set the stage deploying after publish-app. Then awaitDeployment() looked up the Blueprint and set waiting_for_services. The UI does not list deploying. While a run was at that stage, the UI marked no stage as complete or active. Thus the stage list was the same as for a run that did not start. No code, test, or script reads deploying, and the docs do not list it. This change removes it from the workflow, and does not change the UI. The stage stays publishing during the Blueprint lookup. The lookup is normally complete in a few seconds. RunStage no longer has deploying, so tsc gives an error for a new write of it. Now RunStage and stageOrder in public/app.js list the same stages in the same order. A comment on RunStage says to keep them the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt-to-appset the stagedeployingafterpublish-app. ThenawaitDeployment()looked up the Blueprint and setwaiting_for_services.stageOrderinpublic/app.jsdoes not listdeploying. While a run was at that stage, the heading read Deploying, and the UI marked no stage as complete or active. Thus the stage list was the same as for a run that did not start.No code, test, or script reads
deploying. The tests use onlydoneor a mock ofsetRunStage(), andscripts/demo.tsprints each stage that it gets. The docs do not list it. This change removes it from the workflow, and does not change the UI.Changes
app/workflow.ts: the workflow does not setdeployingbeforeawaitDeployment(). The stage stayspublishingduring the Blueprint lookup, which is normally complete in a few seconds.publish-appwrites no progress, so in that time the UI shows Publishing as active, with no progress text.app/store.ts:RunStagehas nodeploying, sotscgives an error for a new write of it. NowRunStageandstageOrderlist the same ten stages in the same order. A comment onRunStagesays to keep the two lists the same.Limits
deployingbefore this change keeps that stage in its row, and the UI shows it as before. Only a run that failed during the Blueprint lookup ended there.deploying.Test plan
npm run check: Biome,tsc, and 376 tests pass.RunStagewithstageOrder: the same ten stages in the same order.tscgives TS2345 forsetRunStage(id, "deploying").🤖 Generated with Claude Code