Explain each stage of a run in a tooltip - #39
Merged
Merged
Conversation
The UI showed the name of each stage, but not what the stage does or where it runs. Now each stage has a tooltip. The tooltip tells what the stage does, and where it runs: a Render Workflows task, the Render Sandbox of the run, or Render itself. The tooltip opens above its stage when the pointer is on the stage, or when the keyboard focuses it. Thus a pointer that moves down the list does not go into an open tooltip. The tooltip touches its stage, so the pointer can move onto it, and Escape closes it (WCAG 1.4.13). The name of each stage is a button, so that the Tab key can go to it. Biome does not let a list item have a tabindex. The stage list is now static HTML. Before, each poll replaced all of the stages, in a live region. That closed an open tooltip, took the focus from a stage, and could make a screen reader read the list again every 5 seconds. Now a poll changes only the class of each stage. RUN_STAGES in app/store.ts now gives the RunStage type. A new gateway test checks that public/index.html lists these stages in this order, each with a tooltip that tells where it runs. Before, only a comment kept the two lists the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The UI showed the name of each stage of a run, but not what the stage does or where it runs. Now each stage has a tooltip that tells both.
architecttask on Render Workflowsprompt-to-apptask on Render Workflowsbuildertask on Render Workflows. Its tools run in the Render Sandbox.verify-apptask on Render Workflows. The builds run in the Render Sandbox.publish-apptask on Render Workflows, in a second Render Sandboxprompt-to-apptask waits on the Render API.deploy-managerandbuildertasks.prompt-to-apptask on Render WorkflowsBehavior
<button>, so that the Tab key can go to it. Biome'snoNoninteractiveTabindexrule does not let a list item have atabindex. The button refers to its tooltip witharia-describedby.aria-liveregion of the run panel. That closed an open tooltip and took the focus from a stage. Now a poll changes only the class of each stage.Stage list check
RUN_STAGESinapp/store.tsnow gives theRunStagetype. A new test intests/gateway.test.tschecks thatpublic/index.htmllists these stages in this order, each with a tooltip that tells where it runs. Before, only a comment kept the two lists the same (PR #38).AGENTS.mdanddocs/FAQ.mdtell about the tooltips.Test plan
npm run check: Biome,tsc, and 377 Vitest tests pass./ui/appsAPI: the tooltips of a running, a deployed, and a failed run. Desktop width, and phone width with no horizontal scroll.🤖 Generated with Claude Code