Repository navigation
fix(deps): sync bun.lock with package.json; align react-dom and eslint-config-next - #1828
Closed
magic-peach wants to merge 1 commit into
Closed
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
…t-config-next #1823 bumped next to 16.4.1 in package.json only, and react-dom had stayed at 19.2.8 while react is 19.3.0, so bun.lock no longer matched package.json: - `bun install --frozen-lockfile` failed; - the lockfile still pinned next 16.3.4 (critical advisories), while plain installs got 16.4.1; - a plain install paired react 19.3.0 with react-dom 19.2.8, so 5 test files failed to load with "Incompatible React versions". react-dom 19.2.8 → 19.3.0 and eslint-config-next 16.3.4 → 16.4.1 (matching next); bun.lock regenerated (42 entries, Next.js packages and the sharp patch Next requires; no majors). Verified: frozen install, 20/20 test files and 241 tests (was 5 files failing), typecheck, lint, production build. bun audit: next now has 0 advisories; the remaining critical is Storybook's dev server (dev-only), handled in the security pipeline work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Contributor
👋 Thanks for your PR, @magic-peach!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This was referenced Nov 3, 2026
magic-peach
added a commit
that referenced
this pull request
Nov 3, 2026
Collaborator
Author
|
Closing as obsolete: main has since moved past this lockfile sync (bun install --frozen-lockfile passes on main, and #1861 upgraded react and react-dom together with bun.lock). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2 of 3. Based on #1827 (it targets
ci/pr-automation-safety, so the diff shows only this change). Merge after #1827.Why
#1823 bumped
nextto 16.4.1 inpackage.jsonbut didn't updatebun.lock, so on main:bun install --frozen-lockfilefails;What this changes
bun.lockregenerated: 42 entries changed, no major version bumps. Nopackage-lock.json.Checks run locally
nexthas 0 advisories.