Skip to content

fix(deps): sync bun.lock with package.json; align react-dom and eslint-config-next - #1828

Closed
magic-peach wants to merge 1 commit into
ci/pr-automation-safetyfrom
fix/lockfile-sync
Closed

magic-peach wants to merge 1 commit into
ci/pr-automation-safetyfrom
fix/lockfile-sync

Conversation

@magic-peach

@magic-peach magic-peach commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Stack 2 of 3. Based on #1827 (it targets ci/pr-automation-safety, so the diff shows only this change). Merge after #1827.

Why

#1823 bumped next to 16.4.1 in package.json but didn't update bun.lock, so on main:

  • bun install --frozen-lockfile fails;
  • the lock still pins next 16.3.4, which has critical advisories;
  • react 19.3.0 vs react-dom 19.2.8 makes 5 test files fail.

What this changes

  • react-dom 19.2.8 → 19.3.0 and eslint-config-next 16.3.4 → 16.4.1, to match react and next.
  • bun.lock regenerated: 42 entries changed, no major version bumps. No package-lock.json.

Checks run locally

  • The frozen install succeeds.
  • 20/20 test files (241 tests), typecheck, lint and build pass (Next 16.4.1).
  • next has 0 advisories.
  • The remaining critical advisory is in Storybook's dev server, which is dev-only and out of scope here.

…t-config-next

#1823 bumped next to 16.4.1 in package.json only, and react-dom had stayed
at 19.2.8 while react is 19.3.0, so bun.lock no longer matched package.json:
- `bun install --frozen-lockfile` failed;
- the lockfile still pinned next 16.3.4 (critical advisories), while plain
  installs got 16.4.1;
- a plain install paired react 19.3.0 with react-dom 19.2.8, so 5 test files
  failed to load with "Incompatible React versions".

react-dom 19.2.8 → 19.3.0 and eslint-config-next 16.3.4 → 16.4.1 (matching
next); bun.lock regenerated (42 entries, Next.js packages and the sharp patch
Next requires; no majors).

Verified: frozen install, 20/20 test files and 241 tests (was 5 files
failing), typecheck, lint, production build. bun audit: next now has 0
advisories; the remaining critical is Storybook's dev server (dev-only),
handled in the security pipeline work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:testing Testing labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @magic-peach

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.
  • ⚠️ Your PR targets ci/pr-automation-safety instead of main. Please check your base branch.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @magic-peach!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@magic-peach

Copy link
Copy Markdown
Collaborator Author

Closing as obsolete: main has since moved past this lockfile sync (bun install --frozen-lockfile passes on main, and #1861 upgraded react and react-dom together with bun.lock).

@magic-peach magic-peach closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant