Repository navigation
ci: Claude PR automation never merges; skip drafts; enforce statically - #1827
Merged
Merged
Conversation
- claude-manager.yml (claude-pr-review): skip draft PRs (`github.event.pull_request.draft == false`), keep the event and author restrictions, rename the step, and replace "squash-merge the PR" with a comment that the PR is ready for a maintainer. The prompt now forbids merging, approving, enabling auto-merge, pushing and marking drafts ready. Permissions unchanged (contents: read). - CLAUDE.md: PR Automation no longer merges; automatic conflict resolution (git merge + push to the PR branch) becomes guidance in a comment; General Rules no longer list "merge PRs". - scripts/ci/check-pr-automation.mjs: fails on merge commands/APIs in any workflow, contents: write / write-all in a Claude job, a PR-writing Claude job without a draft guard, and affirmative merge/push instructions in prompts or CLAUDE.md. Run in lint.yml; unit-tested with passing and failing fixtures (it flags all six items on main today). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit rewrote the file with LF; the net change against main is now only the two added lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for reframe-os ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
level:advanced
Contributor
👋 Thanks for your PR, @magic-peach!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
|
This was referenced Nov 3, 2026
magic-peach
added a commit
that referenced
this pull request
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1 of 3. Merge this first. Then #1828 (lockfile) and #1829 (telemetry), in that order, using merge commits.
What this changes
The
claude-managerworkflow's PR review step could merge PRs. This makes it comment-only:claude-pr-reviewskips draft PRs (github.event.pull_request.draft == false). Its prompt now says never to merge, approve, push or enable auto-merge, and its permissions staycontents: read.scripts/ci/check-pr-automation.mjsruns inlint.ymland fails if any workflow or instruction file starts merging or pushing on its own.src/lib/tests/prAutomationSafety.test.tscovers it (15 tests).origin/mainis merged in (4db46ec); no history was rewritten.Checks run locally
Tests, the safety check and actionlint pass. Expected CI failures not caused by this PR:
claude-review(the Claude GitHub App isn't installed) andDependency scan(snyk.ymlon main uses npm 10, which crashes; it needs npm 11).Open owner PRs #1819, #1805, #1804 and #1801 still run main's old workflow until this merges.