ci: fix Playwright e2e tests in publish-ci examples#5310
Merged
Conversation
aryaemami59
added
Dependencies
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e4fe9df:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bump [`@playwright/test`](https://www.npmjs.com/package/@playwright/test) from `^1.31.1` to `^1.60.0` and remove the redundant standalone `playwright` devDependency in the `cra4`, `cra5`, `next`, and `vite` examples under `examples/publish-ci`. The CI install step fetched the latest Playwright, which installs a newer Chromium build and deletes the one the pinned `1.31.2` version needed, leaving the `test-published-artifact` job without a usable browser. Aligning `@playwright/test` with the installed version keeps the Chromium build in sync and fixes the failing tests.
aryaemami59
force-pushed
the
ci/fix-playwright-tests
branch
from
d3bedac to
e4fe9df
Compare
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cra4,cra5,next, andviteexamples each depended on both@playwright/testand a standaloneplaywright, whose versions could drift and fight over the Chromium build, breaking thetest-published-artifactCI job. This PR consolidates each example to a single Playwright dependency.Changes
@playwright/testfrom^1.31.1to^1.60.0and drop the redundant standaloneplaywrightdevDependency in thecra4,cra5,next, andviteexamples underexamples/publish-ci, with matchingyarn.lockupdates.playwright install --with-deps chromiumstep (gated on thenext,vite,cra4, andcra5matrix examples) so the required Chromium build is present before the test step runs.Related