Skip to content

chore: ignore test-results folder in publish-ci examples#5311

Merged
markerikson merged 1 commit into
reduxjs:masterfrom
aryaemami59:chore/gitignore-test-results-folder
Jun 2, 2026
Merged

chore: ignore test-results folder in publish-ci examples#5311
markerikson merged 1 commit into
reduxjs:masterfrom
aryaemami59:chore/gitignore-test-results-folder

Conversation

@aryaemami59

Copy link
Copy Markdown
Member

Summary

@playwright/test
writes its per-run artifacts (traces, screenshots, videos) to a
test-results/ directory by default. This folder was not ignored in the
publish-ci example projects, so running the Playwright e2e tests locally
left untracked output cluttering git status. This PR ignores it across all
four examples.

Changes

  • Add /test-results/ to the .gitignore of the cra4, cra5,
    next, and vite examples under examples/publish-ci.

Related

  • Follow-up to the Playwright e2e fixes in #5310

@aryaemami59 aryaemami59 self-assigned this Jun 2, 2026
@aryaemami59 aryaemami59 added the Example-Apps Issues related to example apps. label Jun 2, 2026
@codesandbox

codesandbox Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify

netlify Bot commented Jun 2, 2026

Copy link
Copy Markdown

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 91da2ae
🔍 Latest deploy log https://app.netlify.com/projects/redux-starter-kit-docs/deploys/6a1f493d05aeae00098cb281
😎 Deploy Preview https://deploy-preview-5311--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codesandbox-ci

codesandbox-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91da2ae:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@aryaemami59 aryaemami59 requested a review from markerikson June 2, 2026 21:26
@markerikson markerikson merged commit 7c49510 into reduxjs:master Jun 2, 2026
47 checks passed
@aryaemami59 aryaemami59 requested a review from EskiMojo14 June 2, 2026 21:26
@aryaemami59 aryaemami59 deleted the chore/gitignore-test-results-folder branch June 2, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Example-Apps Issues related to example apps.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants