net: isolated SOCKS broadcast of local-origin txs - #649
Open
rearden-grok[bot] wants to merge 7 commits into
Open
rearden-grok[bot] wants to merge 7 commits into
rearden-grok[bot] wants to merge 7 commits into
Conversation
7 tasks
rearden-grok
Bot
force-pushed
the
net/wallet-onion
branch
from
September 20, 2026 02:03
bcaeb41 to
adec5bc
Compare
rearden-grok
Bot
force-pushed
the
net/ephemeral-tor
branch
from
September 20, 2026 02:03
d57d8db to
dbb2140
Compare
rearden-grok
Bot
force-pushed
the
net/wallet-onion
branch
5 times, most recently
from
September 20, 2026 21:15
dd7fb57 to
aab6370
Compare
rearden-grok
Bot
force-pushed
the
net/ephemeral-tor
branch
from
September 20, 2026 21:15
dbb2140 to
3ec3e7d
Compare
rearden-grok
Bot
force-pushed
the
net/wallet-onion
branch
from
September 20, 2026 21:37
aab6370 to
6e4d68b
Compare
rearden-grok
Bot
force-pushed
the
net/ephemeral-tor
branch
from
September 20, 2026 21:37
3ec3e7d to
c39c77d
Compare
Process-RAM set, not a store schema. P2P accept_tx_from does not mark. Later isolated broadcast skips standing INV for these txids. Co-authored-by: Cursor <cursoragent@cursor.com>
Isolated broadcast (on with --proxy/--onion) must not leak a locally submitted tx onto long-lived peers. P2P-originated txs still INV. Co-authored-by: Cursor <cursoragent@cursor.com>
After accept, dial_isolated + BIP324 handshake sends tx to 1–2 AddrMan peers (onion first) and disconnects. Failure logs and does not fall back to standing INV. Fake SOCKS records fresh USERPASS ≠ standing. Co-authored-by: Cursor <cursoragent@cursor.com>
Document that --proxy/--onion skips standing INV for local submits and opens a short-lived SOCKS circuit. Not Dandelion++. NixOS proxy option carries the same fact; no extra flag. Co-authored-by: Cursor <cursoragent@cursor.com>
mark_local_origin on transaction.broadcast / broadcast_package pushed dispatch_pinned over the cognitive-complexity cap. Same accept path. Co-authored-by: Cursor <cursoragent@cursor.com>
coverage-crap scored spawn_isolated_broadcast_loop at 72 because the tokio loop was untested. Drive the helper from units and keep the spawn wrapper thin. Co-authored-by: Cursor <cursoragent@cursor.com>
Direct Socks { proxy, randomize } omitted shared_creds after the stack rebase, so ephemeral-tor and everything above it failed to compile.
Co-authored-by: Cursor <cursoragent@cursor.com>
rearden-grok
Bot
force-pushed
the
net/wallet-onion
branch
from
September 20, 2026 22:09
6e4d68b to
9758405
Compare
rearden-grok
Bot
force-pushed
the
net/ephemeral-tor
branch
from
September 20, 2026 22:09
c39c77d to
8cb09b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plan 06 (
docs/personal-node-plans/06-ephemeral-tor-broadcast.md). Stacked on #648 (net/wallet-onion).--proxyor--onion, standing peers do not INV those txs.dial_isolateds 1–2 AddrMan peers (onion first), BIP324-handshakes, sendstx, disconnects. Fresh SOCKS USERPASS ≠ standing. Failure logs and does not fall back to standing INV.proxydescription documents the behavior.Test plan
cargo test -p rbitcoin-net --lib ephemeral_broadcast_cargo test -p rbitcoin-net --lib local_origin_nix build .#checks.x86_64-linux.nixos-module-eval --no-linkDo not merge unless asked.
Made with Cursor