net: P2P --listen-onion inbound hidden service - #651
Open
rearden-grok[bot] wants to merge 5 commits into
Open
rearden-grok[bot] wants to merge 5 commits into
rearden-grok[bot] wants to merge 5 commits into
Conversation
rearden-grok
Bot
added
the
nixos-module-runtime
7 tasks
Even with --no-listen, start_p2p_bind uses 127.0.0.1:0 so Tor can forward. --max-inbound 0 and missing --tor-control are Config errors. Co-authored-by: Cursor <cursoragent@cursor.com>
Persist {datadir}/onion/p2p.priv. Virtual port is the network default
P2P port; target is the actual loopback listen.
Co-authored-by: Cursor <cursoragent@cursor.com>
PeerHub stores the HS hostname (fake control SIDs are not valid v3). --no-discover still announces onion; clearnet listen off suppresses --external-ip. getnetworkinfo lists the onion. Co-authored-by: Cursor <cursoragent@cursor.com>
First-class NixOS option; After=tor.service already implied by control. Runtime argv greps --listen-onion. Co-authored-by: Cursor <cursoragent@cursor.com>
Dropping the client transport at handshake return raced the accept loop off the snapshot. Hold the session and wait longer. Co-authored-by: Cursor <cursoragent@cursor.com>
rearden-grok
Bot
force-pushed
the
net/ephemeral-tor
branch
from
September 20, 2026 02:03
d57d8db to
dbb2140
Compare
rearden-grok
Bot
force-pushed
the
net/listen-onion
branch
from
September 20, 2026 02:03
80e91aa to
e6a540b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plan 07 (
docs/personal-node-plans/07-p2p-onion-inbound.md). Stacked on #649 (net/ephemeral-tor).--listen-onionwith--no-listenbinds127.0.0.1:0(no0.0.0.0).--max-inbound 0or missing--tor-controlis a Config error.--i2p-accept-incomingmay use that loopback.ADD_ONIONmaps the network default P2P port to the loopback bind and persists{datadir}/onion/p2p.priv(0600). Fake control SID is stored as a hostname string (checksum is not a valid v3).addrv2self-announce sendsAddrV2::TorV3when listen-onion is on.--no-discoverstill gossips the onion and lists it ingetnetworkinfo.localaddresses; it does not gossip--external-ipunless discover and a clearnet listen are on.p2p.listenOnion(default false);After/Wantstor.servicevia existing control. Runtime argv greps--listen-onion.No live Tor. No Arti.
Test plan
cargo test -p rbitcoin-net --lib listen_onion_cargo test -p rbitcoin-net --lib self_announce_onioncargo test -p rbitcoin-node --lib listen_onion_cargo test -p rbitcoin-node --lib p2p_add_onioncargo test -p rbitcoin-rpc --lib getnetworkinfo_includes_p2p_onionnix build .#checks.x86_64-linux.nixos-module-eval --no-linknixos-module-runtimeDo not merge unless asked.
Made with Cursor