Conversation
meta-cla
Bot
added
the
CLA Signed
|
@crazeface has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120641422. |
cortinico
requested changes
Sep 25, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
crazeface
pushed a commit
to crazeface/react-native
that referenced
this pull request
Sep 25, 2026
) Summary: iOS 26 adds scroll edge effects, which UIKit positions in a scroll view's own coordinate space. Inverted virtualized lists are implemented with a `scaleY(-1)` transform on the scroll view, and UIKit does not account for it, so neither effect lands where it belongs: - Against a navigation bar, `topEdgeEffect` darkens the lower half of the screen instead of the content passing under the bar. - Against a bottom bar, `bottomEdgeEffect` dims the entire screen. With both bars present the two stack, leaving content close to unreadable. This reproduces with a plain `UIScrollView` carrying the same transform, with no React Native involved, so the underlying defect is in UIKit rather than here. What can be done from this side is stop the misplaced effects from rendering, so `RCTEnhancedScrollView` now hides both while the scroll view is inverted. Nothing visible is lost by doing so. An inverted list never gets a usable edge effect at any scroll position; the only thing the effects produce while mirrored is the misplaced darkening. Giving the bars correct effects is not possible from here, because UIKit has no notion of the transform. Reported as react-native#54181, migrated from software-mansion/react-native-screens#3293. Changelog: [iOS][Fixed] - Hide the misplaced iOS 26 scroll edge effects on inverted ScrollViews Differential Revision: D120641422
crazeface
force-pushed
the
export-D120641422
branch
from
September 25, 2026 18:04
f057792 to
2701307
Compare
) Summary: Pull Request resolved: react#58684 iOS 26 adds scroll edge effects, which UIKit positions in a scroll view's own coordinate space. Inverted virtualized lists are implemented with a `scaleY(-1)` transform on the scroll view, and UIKit does not account for it, so neither effect lands where it belongs: - Against a navigation bar, `topEdgeEffect` darkens the lower half of the screen instead of the content passing under the bar. - Against a bottom bar, `bottomEdgeEffect` dims the entire screen. With both bars present the two stack, leaving content close to unreadable. This reproduces with a plain `UIScrollView` carrying the same transform, with no React Native involved, so the underlying defect is in UIKit rather than here. What can be done from this side is stop the misplaced effects from rendering, so `RCTEnhancedScrollView` now hides both while the scroll view is inverted. Nothing visible is lost by doing so. An inverted list never gets a usable edge effect at any scroll position; the only thing the effects produce while mirrored is the misplaced darkening. Giving the bars correct effects is not possible from here, because UIKit has no notion of the transform. Reported as react-native#54181, migrated from software-mansion/react-native-screens#3293. Changelog: [iOS][Fixed] - Hide the misplaced iOS 26 scroll edge effects on inverted ScrollViews Differential Revision: D120641422
crazeface
force-pushed
the
export-D120641422
branch
from
September 25, 2026 18:07
2701307 to
a516782
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
iOS 26 adds scroll edge effects, which UIKit positions in a scroll view's own coordinate space. Inverted virtualized lists are implemented with a
scaleY(-1)transform on the scroll view, and UIKit does not account for it, so neither effect lands where it belongs:topEdgeEffectdarkens the lower half of the screen instead of the content passing under the bar.bottomEdgeEffectdims the entire screen.With both bars present the two stack, leaving content close to unreadable.
This reproduces with a plain
UIScrollViewcarrying the same transform, with no React Native involved, so the underlying defect is in UIKit rather than here. What can be done from this side is stop the misplaced effects from rendering, soRCTEnhancedScrollViewnow hides both while the scroll view is inverted.Nothing visible is lost by doing so. An inverted list never gets a usable edge effect at any scroll position; the only thing the effects produce while mirrored is the misplaced darkening. Giving the bars correct effects is not possible from here, because UIKit has no notion of the transform.
Reported as react-native#54181, migrated from software-mansion/react-native-screens#3293.
Changelog:
[iOS][Fixed] - Hide the misplaced iOS 26 scroll edge effects on inverted ScrollViews
Differential Revision: D120641422