-
Notifications
You must be signed in to change notification settings - Fork 6.1k
docs: In case of :hermes_enabled flag, pod install warning added
#4807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,3 +116,5 @@ Edit your `ios/Podfile` file and make the change illustrated below: | |
| :app_path => "#{Pod::Config.instance.installation_root}/.." | ||
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 0.77 is out of the support window, we should not update the docs. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,3 +116,5 @@ Edit your `ios/Podfile` file and make the change illustrated below: | |
| :app_path => "#{Pod::Config.instance.installation_root}/.." | ||
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 0.78 is out of the support window, we should not update the docs. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,3 +116,5 @@ Edit your `ios/Podfile` file and make the change illustrated below: | |
| :app_path => "#{Pod::Config.instance.installation_root}/.." | ||
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 0.79 is out of the support window, we should not update the docs. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not change an old blog post, especially if it is for a version that is out of the support window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I've just encounter and wanted to point out this condition but you're right so on I abandon request.