docs: In case of :hermes_enabled flag, pod install warning added#4807
docs: In case of :hermes_enabled flag, pod install warning added#4807zaferatli wants to merge 1 commit into
:hermes_enabled flag, pod install warning added#4807Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| </TabItem> | ||
| </Tabs> | ||
|
|
||
| Add `export USE_HERMES=true` to `/ios/.xcode.env` for [Hermes bytecoded](https://github.com/facebook/react-native/blob/4d2e38edd97a87e93cb95a8a0021abf73765cf28/packages/react-native/scripts/react-native-xcode.sh#L166C8-L166C18) bundle on iOS. |
There was a problem hiding this comment.
Why are you adding this?
There was a problem hiding this comment.
Because on iOS side without this variable release builds is not rendered by hermes.
There was a problem hiding this comment.
Nope you should not be needing to add export USE_HERMES=true to your .xcode.env file. I think there is something going on in your setup.
There was a problem hiding this comment.
I think there is fuzzy situation, when I add hermes_enable value to Podfile I expected to release build would have been byte coded version as same as android without installing pods with USE_HERMES=1 which is not seems on documantation also.
I'm not quite sure but there is fuzy situation which is not explained on this type. We need to add this USE_HERMES=1 bundle exec pod install or mine idk
There was a problem hiding this comment.
Hermes is the default engine. If you don't specify anything, that would be used by default.
I think that your setup has some issue and that's not the base situation for all our users, so we should not add this into the documentation
| </TabItem> | ||
| </Tabs> | ||
|
|
||
| Add `export USE_HERMES=true` to `/ios/.xcode.env` for [Hermes bytecoded](https://github.com/facebook/react-native/blob/4d2e38edd97a87e93cb95a8a0021abf73765cf28/packages/react-native/scripts/react-native-xcode.sh#L166C8-L166C18) bundle on iOS. |
There was a problem hiding this comment.
Hermes is the default engine. If you don't specify anything, that would be used by default.
I think that your setup has some issue and that's not the base situation for all our users, so we should not add this into the documentation
|
Just to clarify, this flag is only used during the pod installation process. For example, if I change it from true to false, the change won’t take effect until I run pod install again isn't? and this situation is not explicitly informed, I think this case should been added docs, I could add related information in docs if you aggree with me. |
|
@zaferatli correct. That is an env var for Cocoapods only, which controls whether Hermes should be installed. |
zaferatli
changed the title
export USE_HERMES=true warning added.:hermes_enabled flag, pod install warning added
|
@cipolleschi Could you check now? I think we need to inform to |
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
I left some comments. I'd rather not change the docs for outdated version. The goal is to push people on the newer versions of React native.
| _Run `pod install` in case of any `:hermes_enabled` changes._ | ||
|
|
There was a problem hiding this comment.
I would not change an old blog post, especially if it is for a version that is out of the support window.
There was a problem hiding this comment.
I see, I've just encounter and wanted to point out this condition but you're right so on I abandon request.
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ |
There was a problem hiding this comment.
0.77 is out of the support window, we should not update the docs.
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ |
There was a problem hiding this comment.
0.78 is out of the support window, we should not update the docs.
| ) | ||
| ``` | ||
|
|
||
| _Run `pod install` in case of any `:hermes_enabled` changes._ |
There was a problem hiding this comment.
0.79 is out of the support window, we should not update the docs.
3 participants
In case of :hermes_enabled flag, pod install warning added