Skip to content

fix: interface polish — text-wrap, tabular numbers, concentric radius #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ravisuhag wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −8
Open

fix: interface polish — text-wrap, tabular numbers, concentric radius #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/raystack/components/accordion/accordion.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@

@media (prefers-reduced-motion: no-preference) {
.accordion-icon {
transition: transform var(--rs-duration-fast) var(--rs-ease-in-out);
transition: transform var(--rs-duration-fast) var(--rs-ease-out);
}

.accordion-content {
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/callout/callout.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
flex-shrink: 1;
min-width: 0;
overflow-wrap: break-word;
text-wrap: pretty;
}

.actionsContainer {
Expand Down
3 changes: 2 additions & 1 deletion packages/raystack/components/chat/chat.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
.item {
flex-shrink: 0;
min-width: 0;
text-wrap: pretty;
content-visibility: auto;
contain-intrinsic-size: auto 10rem;
}
Expand Down Expand Up @@ -185,7 +186,7 @@
flex-shrink: 0;
width: var(--rs-space-9);
height: var(--rs-space-9);
border-radius: var(--rs-radius-2);
border-radius: var(--rs-radius-1);
background: var(--rs-color-background-neutral-secondary);
color: var(--rs-color-foreground-base-secondary);
overflow: hidden;
Expand Down
3 changes: 2 additions & 1 deletion packages/raystack/components/chip/chip.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@
border-radius: var(--rs-radius-1);
}

.dismiss-button:active {
.dismiss-button:active,
.chip-interactive:active {
transform: scale(var(--rs-scale-pressed-strong));
}

Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/combobox/combobox.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
color: var(--rs-color-foreground-base-primary);
white-space: normal;
word-break: break-word;
border-radius: var(--rs-radius-2);
border-radius: var(--rs-radius-1);
}

.menuitem[data-highlighted] {
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/command/command.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
.empty {
padding: var(--rs-space-7) var(--rs-space-3);
text-align: center;
text-wrap: pretty;
font-family: var(--rs-font-body);
font-size: var(--rs-font-size-small);
line-height: var(--rs-line-height-small);
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/dialog/dialog.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@
font-weight: var(--rs-font-weight-regular);
line-height: var(--rs-line-height-small);
letter-spacing: var(--rs-letter-spacing-small);
text-wrap: pretty;
margin: 0;
}

Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/drawer/drawer.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
line-height: var(--rs-line-height-regular);
letter-spacing: var(--rs-letter-spacing-regular);
color: var(--rs-color-foreground-base-secondary);
text-wrap: pretty;
}

.body {
Expand Down
2 changes: 2 additions & 0 deletions packages/raystack/components/field/field.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
font-size: var(--rs-font-size-mini);
line-height: var(--rs-line-height-mini);
letter-spacing: var(--rs-letter-spacing-mini);
text-wrap: pretty;
margin: 0;
}

Expand All @@ -25,6 +26,7 @@
font-size: var(--rs-font-size-mini);
line-height: var(--rs-line-height-mini);
letter-spacing: var(--rs-letter-spacing-mini);
text-wrap: pretty;
margin: 0;
}

Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/headline/headline.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
font-family: var(--rs-font-title);
font-weight: var(--rs-font-weight-regular);
color: var(--rs-color-foreground-base-primary);
text-wrap: balance;
}

.headline-t1 {
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/indicator/indicator.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
display: inline-flex;
align-items: center;
justify-content: center;
font-variant-numeric: tabular-nums;
border-radius: var(--rs-radius-full);
white-space: nowrap;
font-weight: var(--rs-font-weight-regular);
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/menu/menu.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
justify-content: center;
padding: var(--rs-space-4);
text-align: center;
text-wrap: pretty;
}

.menuBarTrigger[data-pressed] {
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/message/message.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
inside it the bubble just fills what the text needs. */
max-width: 100%;
min-width: 0;
text-wrap: pretty;
padding: var(--rs-space-3) var(--rs-space-4);
border-radius: var(--rs-radius-5);
font-size: var(--rs-font-size-small);
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/meter/meter.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
line-height: var(--rs-line-height-mini);
letter-spacing: var(--rs-letter-spacing-mini);
color: var(--rs-color-foreground-base-primary);
font-variant-numeric: tabular-nums;
text-align: right;
}

Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/progress/progress.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
line-height: var(--rs-line-height-mini);
letter-spacing: var(--rs-letter-spacing-mini);
color: var(--rs-color-foreground-base-primary);
font-variant-numeric: tabular-nums;
text-align: right;
}

Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/reasoning/reasoning.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
flex-direction: column;
gap: var(--rs-space-3);
padding-top: var(--rs-space-3);
text-wrap: pretty;
}

.reasoning-step {
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/select/select.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
color: var(--rs-color-foreground-base-primary);
white-space: normal;
word-break: break-word;
border-radius: var(--rs-radius-2);
border-radius: var(--rs-radius-1);
}

.menuitem[data-highlighted] {
Expand Down
1 change: 0 additions & 1 deletion packages/raystack/components/switch/switch.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
background: var(--rs-color-foreground-base-emphasis);
border-radius: var(--rs-radius-full);
transform: translateX(var(--rs-space-1));
will-change: transform;
}

@media (prefers-reduced-motion: no-preference) {
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/text/text.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.text {
margin: 0;
color: var(--rs-color-foreground-base-primary);
text-wrap: pretty;
}

/* Text Size */
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/toast/toast.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@
/* ===== Description ===== */
.description {
color: var(--rs-color-foreground-base-primary);
text-wrap: pretty;
font-size: var(--rs-font-size-small);
font-weight: var(--rs-font-weight-regular);
line-height: var(--rs-line-height-small);
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/toggle/toggle.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
transition: color var(--rs-duration-normal) var(--rs-ease-out);
background-color: var(--rs-color-background-base-secondary);
border: 0.5px solid var(--rs-color-border-base-primary);
border-radius: var(--rs-radius-1);
border-radius: var(--rs-radius-2);
}
.toggleContent {
border-radius: var(--rs-radius-1);
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/toolbar/toolbar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.root {
padding: var(--rs-space-1);
border: 0.5px solid var(--rs-color-border-base-primary);
border-radius: var(--rs-radius-2);
border-radius: var(--rs-radius-3);
overflow: clip;
}
.root,
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/tooltip/tooltip.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
letter-spacing: var(--rs-letter-spacing-mini);
width: fit-content;
max-width: 400px;
text-wrap: pretty;
transition: opacity var(--rs-duration-fast) var(--rs-ease-out);
}

Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/tour/tour-parts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export function TourProgress({ format, ...props }: TourProgressProps) {
size='mini'
weight='medium'
variant='secondary'
style={{ fontVariantNumeric: 'tabular-nums' }}
{...props}
Comment on lines +67 to 68

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Preserve tabular numerals when callers pass style.

TourProgressProps accepts the style prop. Because {...props} follows the explicit style, a caller-provided style replaces the inline object and removes fontVariantNumeric: 'tabular-nums'.

The supplied tour namespace exports this component as public Tour.Progress.

Proposed fix 
-      style={{ fontVariantNumeric: 'tabular-nums' }}
       {...props}
+      style={{ ...props.style, fontVariantNumeric: 'tabular-nums' }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
style={{ fontVariantNumeric: 'tabular-nums' }}
{...props}
{...props}
style={{ ...props.style, fontVariantNumeric: 'tabular-nums' }}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/raystack/components/tour/tour-parts.tsx` around lines 67 - 68,
Update the public Tour.Progress component’s style prop handling so
caller-provided styles are merged with, rather than replace, the default
fontVariantNumeric: 'tabular-nums' style. Adjust the prop spread/order in the
component while preserving all other forwarded props.

>
{format ? format(index, steps.length) : `${index + 1} of ${steps.length}`}
Expand Down
1 change: 1 addition & 0 deletions packages/raystack/components/tour/tour.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@
line-height: var(--rs-line-height-small);
letter-spacing: var(--rs-letter-spacing-small);
color: var(--rs-color-foreground-base-secondary);
text-wrap: pretty;
}

.footer {
Expand Down