fix: interface polish — text-wrap, tabular numbers, concentric radius - #882
Open
ravisuhag wants to merge 1 commit into
Open
fix: interface polish — text-wrap, tabular numbers, concentric radius#882ravisuhag wants to merge 1 commit into
ravisuhag wants to merge 1 commit into
Conversation
Apply small polish fixes across the design system, all in the --rs-* token system. Hit-area findings are intentionally left out of this PR. - text-wrap: pretty on body copy (tooltip, callout, toast, chat, message, command/menu empty states, dialog/drawer/tour descriptions, field description + error, reasoning, base Text); balance on the Headline class so it holds when render swaps the tag - font-variant-numeric: tabular-nums on live numbers (meter, progress, indicator, tour step counter) to stop digit jitter - concentric radius: toggle, toolbar, select/combobox items, chat thumb - accordion chevron shares the panel ease-out curve; interactive chips get the press scale their dismiss button already had - drop always-on will-change on the switch thumb
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughUpdated component styling across Raystack. Text content now uses improved or balanced wrapping in multiple components. Numeric values use tabular glyphs. Several controls received border-radius, transition, pressed-state, and rendering updates. Attachment media and toolbar geometry also changed. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/raystack/components/tour/tour-parts.tsx`:
- Around line 67-68: Update the public Tour.Progress component’s style prop
handling so caller-provided styles are merged with, rather than replace, the
default fontVariantNumeric: 'tabular-nums' style. Adjust the prop spread/order
in the component while preserving all other forwarded props.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 59e266e5-4a5c-4ebc-9f27-4828e5c5f932
📒 Files selected for processing (25)
packages/raystack/components/accordion/accordion.module.csspackages/raystack/components/callout/callout.module.csspackages/raystack/components/chat/chat.module.csspackages/raystack/components/chip/chip.module.csspackages/raystack/components/combobox/combobox.module.csspackages/raystack/components/command/command.module.csspackages/raystack/components/dialog/dialog.module.csspackages/raystack/components/drawer/drawer.module.csspackages/raystack/components/field/field.module.csspackages/raystack/components/headline/headline.module.csspackages/raystack/components/indicator/indicator.module.csspackages/raystack/components/menu/menu.module.csspackages/raystack/components/message/message.module.csspackages/raystack/components/meter/meter.module.csspackages/raystack/components/progress/progress.module.csspackages/raystack/components/reasoning/reasoning.module.csspackages/raystack/components/select/select.module.csspackages/raystack/components/switch/switch.module.csspackages/raystack/components/text/text.module.csspackages/raystack/components/toast/toast.module.csspackages/raystack/components/toggle/toggle.module.csspackages/raystack/components/toolbar/toolbar.module.csspackages/raystack/components/tooltip/tooltip.module.csspackages/raystack/components/tour/tour-parts.tsxpackages/raystack/components/tour/tour.module.css
💤 Files with no reviewable changes (1)
- packages/raystack/components/switch/switch.module.css
Comment on lines
+67
to
68
| style={{ fontVariantNumeric: 'tabular-nums' }} | ||
| {...props} |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve tabular numerals when callers pass style.
TourProgressProps accepts the style prop. Because {...props} follows the explicit style, a caller-provided style replaces the inline object and removes fontVariantNumeric: 'tabular-nums'.
The supplied tour namespace exports this component as public Tour.Progress.
Proposed fix
- style={{ fontVariantNumeric: 'tabular-nums' }}
{...props}
+ style={{ ...props.style, fontVariantNumeric: 'tabular-nums' }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| style={{ fontVariantNumeric: 'tabular-nums' }} | |
| {...props} | |
| {...props} | |
| style={{ ...props.style, fontVariantNumeric: 'tabular-nums' }} |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/raystack/components/tour/tour-parts.tsx` around lines 67 - 68,
Update the public Tour.Progress component’s style prop handling so
caller-provided styles are merged with, rather than replace, the default
fontVariantNumeric: 'tabular-nums' style. Adjust the prop spread/order in the
component while preserving all other forwarded props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small interface-polish fixes across the design system, from a full
/make-interfaces-feel-bettersweep of all 76 components. Every change stays in the existing--rs-*token system. No new styling approach, no API changes.Hit-area findings (the one HIGH systemic issue — small
IconButtonclose/dismiss targets) are left out on purpose and tracked as a follow-up.Changes
Text wrapping
text-wrap: prettyon body copy: tooltip, callout, toast, chat item, message bubble, command/menu empty states, dialog/drawer/tour descriptions, field description + error, reasoning body, and the baseTextprimitive.text-wrap: balanceon theHeadlineclass so it holds whenrenderswaps the tag (globalbalanceonly lands on realh1–h4).Tabular numbers
font-variant-numeric: tabular-numson live numbers: meter value, progress value, indicator badge, tour step counter. Stops horizontal jitter as digit widths change.Concentric radius (outer = inner + padding)
radius-1→radius-2, toolbarradius-2→radius-3, select/combobox menu itemsradius-2→radius-1, chat attachment thumbradius-2→radius-1.Animations
ease-outcurve so they move as one.--rs-scale-pressed-strongpress feedback their dismiss button already had (a chip is interactive or dismissible, never both).Performance
will-change: transformfrom the switch thumb.Verification
Biome clean (pre-commit passed). Changes are additive one-liners in the token system. Not driven in a browser — reviewer should confirm meter/progress digit stability and the accordion chevron/panel timing in the Animations panel.