Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [Request] Treat IPv6 literals as non-domain hosts.
- [Router] Fall back to `SERVER_NAME` when deriving exact host constraints.
- [Cookies] Use request host fallback when resolving cookie domains.
- [Cookies] Match array-based cookie domains case-insensitively.

## [1.25.1] - 2026-06-08

Expand Down
2 changes: 1 addition & 1 deletion lib/rage/cookies.rb
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def []=(key, value)
elsif domain == :all
DomainName(host).domain
elsif domain.is_a?(Array)
host if domain.include?(host)
domain.find { |candidate| candidate.casecmp?(host) } if host
end
end

Expand Down
26 changes: 26 additions & 0 deletions spec/controller/api/cookies_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,32 @@
end
end

context "when request host uses different casing" do
let(:request_host) { "COOKIE.TEST.COM" }

it "correctly sets domain value" do
subject.cookies[:user_id] = {
domain: %w(api.test.com cookie.test.com),
value: 120
}

expect(response_cookies[:user_id]).to eq("120; domain=cookie.test.com")
end
end

context "when request host uses different casing and includes a port" do
let(:request_host) { "COOKIE.TEST.COM:3000" }

it "correctly sets domain value" do
subject.cookies[:user_id] = {
domain: %w(api.test.com cookie.test.com),
value: 120
}

expect(response_cookies[:user_id]).to eq("120; domain=cookie.test.com")
end
end

context "when request uses SERVER_NAME fallback" do
let(:request_env) do
{
Expand Down