[Cookies] Match array-based cookie domains case-insensitively#328
Merged
rsamoilov merged 1 commit intoJun 14, 2026
Merged
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #327 reported that array-based cookie domains were matched with exact string equality, so uppercase request hosts did not match lowercase configured domains.
This PR updates
Rage::Cookies#[]=to match array-based cookie domains case-insensitively while still using the configured domain value in theSet-Cookieheader.It also adds regression tests for uppercase hosts with and without a port, and updates
CHANGELOG.md.Closes #327.
Checklist:
bundle exec rubocop --except Layout/EndOfLine lib/rage/cookies.rb spec/controller/api/cookies_spec.rb.bundle exec rspec spec/controller/api/cookies_spec.rb.bundle exec rspec spec/controller/api spec/router/constraints_spec.rb.Before the fix:
After the fix: