Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion catalog/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"use-debounce": "^9.0.4",
"use-resize-observer": "^9.1.0",
"uuid": "^9.0.1",
"vega": "^5.33.0",
"vega": "^6.0.0",
"vega-embed": "^6.22.2",
"vega-lite": "^5.14.1",
Comment on lines +141 to 143
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incomplete upgrade — mismatched vega ecosystem versions

vega has been bumped to ^6.0.0, but vega-embed (still at ^6.22.2) and vega-lite (still at ^5.14.1) are not compatible with vega 6. The correct version trio for vega 6 is:

Package Required for vega 6
vega ^6.0.0
vega-lite ^6.x ❌ (currently ^5.14.1)
vega-embed ^7.x ❌ (currently ^6.22.2)

The official vega-lite embedding docs confirm this combination (e.g., vega@6, vega-lite@6, vega-embed@7). Both vega-embed@6 and vega-lite@5 declare vega@^5 as a peer dependency, which conflicts with the newly installed vega@6. This likely produces npm peer-dependency warnings at install time and may result in two copies of vega being bundled, or runtime errors.

Additionally, vega 6.0.0 is ESM-only (no CJS/UMD bundles), which may require webpack configuration changes depending on how the project bundles the library.

The package-lock.json also still pins vega to 5.33.0, meaning npm ci will install the old version — the lock file must be regenerated after fixing the version matrix.

"warning": "^4.0.3",
Expand Down
Loading