fix(deps): update dependency vega to v6 [security]#4643
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
fix(deps): update dependency vega to v6 [security]#4643renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4643 +/- ##
===========================================
+ Coverage 45.62% 94.05% +48.42%
===========================================
Files 831 146 -685
Lines 33597 11766 -21831
Branches 5727 0 -5727
===========================================
- Hits 15328 11066 -4262
+ Misses 16264 700 -15564
+ Partials 2005 0 -2005
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
from
5ab2eec to
4ac4b13
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
4 times, most recently
from
9a7a88d to
2b7fe43
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
9 times, most recently
from
a1eea51 to
3a0f97f
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
7 times, most recently
from
6d0f34e to
7f3cd14
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
4 times, most recently
from
df05d8c to
5797da0
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
3 times, most recently
from
ff7546e to
339e75a
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
from
339e75a to
1db738a
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
4 times, most recently
from
09b552a to
9b94fe0
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
2 times, most recently
from
362dd2c to
54a1b22
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
8 times, most recently
from
cbe5699 to
362fe00
Compare
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
3 times, most recently
from
2c5d4ce to
81ec34b
Compare
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/npm-vega-vulnerability
branch
from
647613f to
81ec34b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+141
to
143
| "vega": "^6.0.0", | ||
| "vega-embed": "^6.22.2", | ||
| "vega-lite": "^5.14.1", |
Contributor
There was a problem hiding this comment.
vega has been bumped to ^6.0.0, but vega-embed (still at ^6.22.2) and vega-lite (still at ^5.14.1) are not compatible with vega 6. The correct version trio for vega 6 is:
| Package | Required for vega 6 |
|---|---|
vega |
^6.0.0 ✅ |
vega-lite |
^6.x ❌ (currently ^5.14.1) |
vega-embed |
^7.x ❌ (currently ^6.22.2) |
The official vega-lite embedding docs confirm this combination (e.g., vega@6, vega-lite@6, vega-embed@7). Both vega-embed@6 and vega-lite@5 declare vega@^5 as a peer dependency, which conflicts with the newly installed vega@6. This likely produces npm peer-dependency warnings at install time and may result in two copies of vega being bundled, or runtime errors.
Additionally, vega 6.0.0 is ESM-only (no CJS/UMD bundles), which may require webpack configuration changes depending on how the project bundles the library.
The package-lock.json also still pins vega to 5.33.0, meaning npm ci will install the old version — the lock file must be regenerated after fixing the version matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.33.0→^6.0.0GitHub Vulnerability Alerts
CVE-2025-59840
Impact
Applications meeting 2 conditions are at risk of arbitrary JavaScript code execution, even if "safe mode" expressionInterpreter is used.
vegain an application that attachesvegalibrary and avega.Viewinstance similar to the Vega Editor to the globalwindowJSONdefinitions (vs JSON that was is only provided through source code)Patches
vega6.2.0/vega-expression6.1.0/vega-interpreter2.2.1(if using AST evaluator mode)vega-expression5.2.1/1.2.1(if using AST evaluator mode)Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading
vegaView instances to global variables, as Vega editor used to do herevegato the global window as the editor used to do hereThese practices of attaching the vega library and View instances may be convenient for debugging, but should not be used in production or in any situation where vega/vega-lite definitions could be provided by untrusted parties.
POC Summary
Vega offers the evaluation of expressions in a secure context. Arbitrary function call is prohibited. When an event is exposed to an expression, member get of window objects is possible. Because of this exposure, in some applications, a crafted object that overrides its toString method with a function that results in calling
this.foo(this.bar), DOM XSS can be achieved.In practice, an accessible gadget like this exists in the global VEGA_DEBUG code.
POC Details
{ "$schema": "https://vega.github.io/schema/vega/v5.json", "width": 350, "height": 350, "autosize": "none", "description": "Toggle Button", "signals": [ { "name": "toggle", "value": true, "on": [ { "events": {"type": "click", "markname": "circle"}, "update": "toggle ? false : true" } ] }, { "name": "addFilter", "on": [ { "events": {"type": "mousemove", "source": "window"}, "update": "({toString:event.view.VEGA_DEBUG.vega.CanvasHandler.prototype.on, eventName:event.view.console.log,_handlers:{undefined:'alert(origin + ` XSS on version `+ VEGA_DEBUG.VEGA_VERSION)'},_handlerIndex:event.view.eval})+1" } ] } ] }This payload creates a scenario where whenever the mouse is moved, the toString function of the provided object is implicitly called when trying to resolve adding it with 1. The toString function has been overridden to a "gadget function" (VEGA_DEBUG.vega.CanvasHandler.prototype.on) that does the following:
uto the result of callingthis.eventNamewith undefineddtothis._handlersthis._handlerIndexwith the result ofuindexed into thedobject as the first argument, and undefined as the second two._handlerIndexis set to window.eval, and when indexing undefined into the_handlers, a string to be evald containing the XSS payload is returned.This results in XSS by using a globally scoped gadget to get full blown eval.
PoC Link
Navigate to vega editor, move the mouse, and observe that the arbitrary JavaScript from the configuration reaches the eval sink and DOM XSS is achieved.
Future investigation
In cases where
VEGA_DEBUGis not enabled, there theoreticallycould be other gadgets on the global scope that allow for similar behavior. In cases where AST evaluator is used and there are blocks against getting references toeval, in theory there could be other gadgets on global scope (i.e. jQuery) that would allow for eval the same way (i.e.$.globalEval). As of this writing, no such globally scoped gadgets have been found.Impact
This vulnerability allows for DOM XSS, potentially stored, potentially reflected, depending on how the library is being used. The vulnerability requires user interaction with the page to trigger.
An attacker can exploit this issue by tricking a user into opening a malicious Vega specification. Successful exploitation allows the attacker to execute arbitrary JavaScript in the context of the application’s domain. This can lead to theft of sensitive information such as authentication tokens, manipulation of data displayed to the user, or execution of unauthorized actions on behalf of the victim. This exploit compromises confidentiality and integrity of impacted applications.
Release Notes
vega/vega (vega)
v6.2.0Compare Source
What's Changed
New Contributors
Full Changelog: vega/vega@v6.1.2...v6.2.0
v6.1.2Compare Source
Full Changelog: vega/vega@v6.1.1...v6.1.2
v6.1.1Compare Source
Full Changelog: vega/vega@v6.1.0...v6.1.1
v6.1.0Compare Source
What's Changed
Full Changelog: vega/vega@v6.0.0...v6.1.0
v6.0.0Compare Source
changes since v5.33.0
monorepo
vega-typings
docs
v5.33.1Compare Source
What's Changed
Fixes GHSA-7f2v-3qq3-vvjf for v5 releases
Full Changelog: vega/vega@v5.33.0...v5.33.1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.