Clean XpuptiActivityApi::singleton() and virtual keyword usage#1313
Open
moksiuc wants to merge 9 commits intopytorch:mainfrom
Open
Clean XpuptiActivityApi::singleton() and virtual keyword usage#1313moksiuc wants to merge 9 commits intopytorch:mainfrom
moksiuc wants to merge 9 commits intopytorch:mainfrom
Conversation
Stop methods [push|pop]CorrelationID being static and getting api singleton.
moksiuc
changed the title
Contributor
Author
moksiuc
changed the title
|
The original code aligns with CuPTI and others. Let's keep it as is unless we must have it in future. |
Contributor
Author
Maybe it is necessary in their case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop methods [push|pop]CorrelationID being static and getting api singleton.
Remove unnecessary virtual keywords.