Introduce XPU scope profiler extending existing XPU profiler plugin#1174
Introduce XPU scope profiler extending existing XPU profiler plugin#1174moksiuc wants to merge 109 commits intopytorch:mainfrom
Conversation
|
@moksiuc It's great that we are going to update our PTI integration code, and introduce new profiler path.
|
|
For sure not in this PR. I'll add this to our list of tasks. |
Extracted clean up and adding config for scope profiler to separate PR's. |
- place of config initialization - removal of passing unused C compiler flag into test cmake file
|
@moksiuc Let's close this PR. |
|
@gujinghui this is the core of the scope profiler. When 2 smaller parts are merged this one would have only core profiler left. |
This reverts commit f55b81c.
This reverts commit 4943d72.
|
@divyanshk This PR is ready now. Could you help review? Thanks. |
divyanshk
left a comment
There was a problem hiding this comment.
Left some comments. Important one is in ActivityType.h
I need to look again at output_json.cpp.
|
@divyanshk @scotts all comments have been addressed. Could you help review again? Thanks. |
Summary:
As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. In this PR, the XPU scope profiler is introduced by extending existing XPU profiler plugin. The XPU scope profiler is built on the foundation of intel PTI toolkit (https://github.com/intel/pti-gpu), and underlying SYCL runtime. It allows to gather XPU hardware metrics. The LIBKINETO_NOXPUPTI option is used to enable or disable the whole XPU profiler plugin during kineto build stage.
Changes: