Skip to content

Code cleanup of XPU profiler for incoming scope profiler#1177

Closed
moksiuc wants to merge 5 commits intopytorch:mainfrom
moksiuc:moksiuci_6674_scope_profiler_pre
Closed

Code cleanup of XPU profiler for incoming scope profiler#1177
moksiuc wants to merge 5 commits intopytorch:mainfrom
moksiuc:moksiuci_6674_scope_profiler_pre

Conversation

@moksiuc
Copy link
Copy Markdown
Contributor

@moksiuc moksiuc commented Nov 14, 2025

Summary:

Code cleanup of XPU profiler plugin to prepare it for incoming PR with implementation of XPU scope profiler.

Changes:

  • removed unused code
  • clean up lists of included headers
  • added missing copyright headers
  • simplified algorithms
  • run clang-format

@meta-cla meta-cla bot added the cla signed label Nov 14, 2025
@moksiuc moksiuc changed the title Code cleanup for scope profiler Code cleanup of XPU profiler for incoming scope profiler Nov 14, 2025
@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Nov 14, 2025

@EikanWang, @gujinghui
First PR extracted from:
#1174

Comment thread libkineto/src/plugin/xpupti/XpuptiActivityHandlers.cpp Outdated
Comment thread libkineto/src/plugin/xpupti/XpuptiActivityHandlers.cpp
Comment thread libkineto/src/plugin/xpupti/XpuptiActivityApi.cpp
@moksiuc moksiuc requested a review from gujinghui November 17, 2025 10:15
@gujinghui
Copy link
Copy Markdown

@sraikund16 Could you help review this PR? Thanks.

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Dec 1, 2025

@sraikund16, could you review or suggest who else could do it ?

@gujinghui
Copy link
Copy Markdown

@malfet could you help review this PR? Thanks.

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 9, 2025

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this in D88693420.

Copy link
Copy Markdown
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@sraikund16
Copy link
Copy Markdown
Contributor

@moksiuc Can you make these lint changes? moksiuc#4

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@moksiuc has updated the pull request. You must reimport the pull request before landing.

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Dec 16, 2025

@moksiuc Can you make these lint changes? moksiuc#4

@sraikund16 done

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Dec 16, 2025

@sraikund16 how to run linter in this repo so I had correct format the next time ?

@sraikund16
Copy link
Copy Markdown
Contributor

@sraikund16 how to run linter in this repo so I had correct format the next time ?

Unfortunately we don't have a linter in Kineto externally. We plan on adding it in the coming half

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Dec 17, 2025

@sraikund16 merged this pull request in 2a430df.

@moksiuc moksiuc deleted the moksiuci_6674_scope_profiler_pre branch December 17, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants