Skip to content

[ExecuTorch][Vulkan] Add et_vk.adamw_step kernel (on-GPU AdamW optimizer step)#20937

Merged
meta-codesync[bot] merged 8 commits into
gh/JCNTH/76/basefrom
gh/JCNTH/76/head
Jul 21, 2026
Merged

[ExecuTorch][Vulkan] Add et_vk.adamw_step kernel (on-GPU AdamW optimizer step)#20937
meta-codesync[bot] merged 8 commits into
gh/JCNTH/76/basefrom
gh/JCNTH/76/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Vulkan GLSL kernel + handler for the training custom op et_vk.adamw_step (elementwise in-place AdamW parameter update). Mirrors impl/BinaryOp.cpp elementwise structure + unary_op.glsl push-constant scalars; param/m/v are read-modify-write (kReadWrite). AOT registration already exists under the shared Vulkan partitioner.
@exported-using-ghexport

Differential Revision: D111761777

Differential Revision: D111761777

[ghstack-poisoned]
@JCNTH
JCNTH requested a review from SS-JIA as a code owner July 14, 2026 21:49
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 14, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20937

Note: Links to docs will display an error until the docs builds have been completed.

❌ You can merge normally! (2 Unrelated Failures), 6 Unclassified Failures

As of commit 5a17226 with merge base 21554e5 (image):

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 14, 2026
[ghstack-poisoned]
@meta-codesync
meta-codesync Bot merged commit eaba85e into gh/JCNTH/76/base Jul 21, 2026
178 of 188 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/JCNTH/76/head branch July 21, 2026 16:24
@meta-codesync
meta-codesync Bot temporarily deployed to cherry-pick-bot July 21, 2026 16:24 Inactive
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
JCNTH added a commit that referenced this pull request Jul 21, 2026
…zer step)

Pull Request resolved: #20937

Vulkan GLSL kernel + handler for the training custom op `et_vk.adamw_step` (elementwise in-place AdamW parameter update). Mirrors `impl/BinaryOp.cpp` elementwise structure + `unary_op.glsl` push-constant scalars; param/m/v are read-modify-write (`kReadWrite`). AOT registration already exists under the shared Vulkan partitioner.
ghstack-source-id: 405026087
@exported-using-ghexport

Differential Revision: [D111761777](https://our.internmc.facebook.com/intern/diff/D111761777/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants