Skip to content

Fix pyre type errors in parallelism.py (reap OMH type-checking FAILURE) #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q10 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pyre type errors in parallelism.py (reap OMH type-checking FAILURE) #6089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fbgemm_gpu/experimental/gen_ai/test/moe/parallelism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ def init_parallel(
):
ranks = list(range(base_rank, base_rank + mp_size_for_routed_experts))
group = torch.distributed.new_group(ranks, timeout=timeout)
# new_group is typed Union[int, ProcessGroup] in the stubs; it returns a
# ProcessGroup here. Narrow it so the Optional[ProcessGroup] global assigns.
assert isinstance(group, ProcessGroup)
if global_rank in ranks:
_ROUTED_EXPERTS_MP_GROUP = group

Expand All @@ -126,5 +129,8 @@ def init_parallel(
for i in range(num_ep_groups):
ranks = list(range(i, get_world_size(), num_ep_groups))
group = torch.distributed.new_group(ranks, timeout=timeout)
# new_group is typed Union[int, ProcessGroup] in the stubs; it returns a
# ProcessGroup here. Narrow it so the Optional[ProcessGroup] global assigns.
assert isinstance(group, ProcessGroup)
if global_rank in ranks:
_EP_GROUP = group
Loading