Fix pyre type errors in parallelism.py (reap OMH type-checking FAILURE) - #6089
Open
q10 wants to merge 1 commit into
Open
Fix pyre type errors in parallelism.py (reap OMH type-checking FAILURE)#6089q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
Summary: moe:parallelism-type-checking has 42 consecutive FAILUREs (DISABLED_FAILING) on the fbgemm_dev OMH dashboard with detail 'type errors!'. torch.distributed.new_group is typed Union[int, ProcessGroup] in the stubs, but _ROUTED_EXPERTS_MP_GROUP and _EP_GROUP are Optional[ProcessGroup], so the assignments failed pyre [9] Incompatible variable type. Narrow the returned group with assert isinstance(group, ProcessGroup) at both call sites (matches the file's existing assert style; new_group returns a ProcessGroup here). Differential Revision: D113992766
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113992766. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
moe:parallelism-type-checking has 42 consecutive FAILUREs (DISABLED_FAILING) on the
fbgemm_dev OMH dashboard with detail 'type errors!'. torch.distributed.new_group is
typed Union[int, ProcessGroup] in the stubs, but _ROUTED_EXPERTS_MP_GROUP and _EP_GROUP
are Optional[ProcessGroup], so the assignments failed pyre [9] Incompatible variable type.
Narrow the returned group with assert isinstance(group, ProcessGroup) at both call sites
(matches the file's existing assert style; new_group returns a ProcessGroup here).
Differential Revision: D113992766