rename losses.py to soiling.py

[cwhanse]

• Closes move kimber and HSU to soiling.py and remove losses.py #935
• I am familiar with the contributing guidelines
• Updates entries to docs/sphinx/source/api.rst for API changes.
• Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
• Pull request is nearly complete and ready for detailed review.
• Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Renames pvlib.losses to pvlib.soiling, functions renamed from pvlib.losses.soiling_hsu to pvlib.soiling.hsu, and pvlib.losses.soiling_kimber to pvlib.soiling.kimber

[cwhanse]

RTD build fail looks related to not getting forecast data from a server.

[kandersolar]

The Kimber gallery example will need updates as well.

[cwhanse]

The Kimber gallery example will need updates as well.

Done. Do you think that caused the test failure? It was unclear to me where the failure happened.

[cwhanse]

This is ready for review. Open issue: deprecate this change, or just make the change?

[kandersolar]

Done. Do you think that caused the test failure? It was unclear to me where the failure happened.

Building that commit locally (make html) does raise a non-zero error code without the forecast issues. Not sure if the forecast error would still have failed the build anyway if everything else was successful.

[mikofski]

LGTM. Thanks Cliff!

[wholmgren]

I think I brought this up somewhere else and apologies if I have forgotten what was decided: Do we want to deprecate losses.soiling_hsu or just make the change? kimber is new in 0.7.2 so no need to deprecate it.

[cwhanse]

I think I brought this up somewhere else and apologies if I have forgotten what was decided: Do we want to deprecate losses.soiling_hsu or just make the change?

My vote is not to deprecate and just move to soiling.py

[mikofski]

Can I abstain? I don't want to vote

[cwhanse]

Can I abstain? I don't want to vote

Yes. Hearing nothing more, the "aye" has it. No deprecation on renaming losses.py.

[cwhanse]

@CameronTStark can you see what is going on with the py3.6 and py3.7 tests for pvlib.forecast.py? I've re-run the failed tests, same result. Maybe the data server is down, but if so I don't understand why py3.5 tests would pass.

[CameronTStark]

@CameronTStark can you see what is going on with the py3.6 and py3.7 tests for pvlib.forecast.py? I've re-run the failed tests, same result. Maybe the data server is down, but if so I don't understand why py3.5 tests would pass.

The CI test failures here aren't due to anything in this PR and I suspect the failures are due to the external API.

The failures come from test_forecast.py pulling data with NAM() five times and once with GFS() with errors pertaining to TypeError: <class 'cftime._cftime.DatetimeGregorian'> is not convertible to datetime. I ran this PR locally and didn't get the same failures so this may be tricky.

I'm considering separating the --remote-data runs entirely so it can be easier to surmise if the issue is external. Edit: this would lower coverage percentage unfortunately

I'll keep an eye out for results from new PRs while digging further. Thanks for highlighting it @cwhanse!

[CameronTStark]

Thanks @cwhanse!

[nassim86]

hey everyone . i want to print atabnle of monthly value of soiling loss as a table to get the value of each month instead of a plot in kimber model . pleas help.
thank you

[kandersolar]

Hi @nassim86, we use this forum for developing the package, but your question is more about usage. Can you please repost your question to the pvlib google group instead of here? It would probably also be helpful to include more detail about what exactly you want to calculate. Thanks! https://groups.google.com/g/pvlib-python