add temperature.sapm_cell_from_module#938
Merged
Merged
Conversation
mikofski
reviewed
Mar 20, 2020
mikofski
reviewed
Mar 20, 2020
wholmgren
reviewed
Mar 21, 2020
Co-Authored-By: Will Holmgren <william.holmgren@gmail.com>
Contributor
|
Just FYI, I re-ran the two failing conda_windows tests and they came back passing. I did so while comparing CI failures in PRs to compare to the ones that popped up for #937 (spoiler: they were different). |
CameronTStark
approved these changes
Apr 5, 2020
Closed
… into cell_from_mod
wholmgren
approved these changes
Apr 6, 2020
Contributor
cwhanse
changed the title
Contributor
|
Thank you @cwhanse! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).