Remove bonus/optional run concept#196
Merged
Merged
Conversation
The Volume Trend tooltip showed identical Planned and Total values for every week because the optional/bonus classifier in VolumeTrendChart matched nothing the planner generates today. Rather than patch the regex, drop the whole concept: all planned events are just planned events. - VolumeTrendChart: collapse to one Planned bar + one Actual bar, drop plannedOptional/plannedTotal/the "Optional" legend chip - Drop bonus|optional regex sniffing from IntelScreen, AgendaView, eventStyles, constants category mapping, adaptPlan external_id - Adapt prompt example: "Bonus easy" → "Easy" - CLAUDE.md: drop Saturday-bonus naming rule and Easy/Bonus row in Fuel Taper - Free Run note no longer calls itself "bonus volume" — free runs are unstructured, not optional Free runs (the "no rules" Saturday session) are unchanged. Demo fixtures keep their historical "Bonus Easy" names; with classifiers gone they now render as plain easy events. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- docs/workout-reference.md: delete Example G (Bonus Easy) — the CLAUDE.md-anointed reference doc was still teaching a workout type the system no longer generates - lib/workoutGenerators.ts: make Free Run truly free — 1 hour, no pace zone (z1 → null/null bands), note text matches the unstructured step. Previously the note claimed "no rules" but the watch dictated z2 pace bands for 30m. - lib/eventStyles.ts + app/components/AgendaView.tsx: drop the redundant `if (race) return brand` branches that became identical to the fallback after the bonus branch was removed - scripts/demo-snapshot.ts: strip "Bonus" from normalized workout names so future snapshots stay clean - lib/demo/fixtures.ts: rename two historical "Bonus Easy" entries to "Easy" to match the new naming Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlannedandTotalfor every week because thebonus|optionalregex inVolumeTrendChartmatched nothing the planner actually generates.What changed
VolumeTrendChart: collapse to one Planned bar + one Actual bar, dropplannedOptional/plannedTotaland the "Optional" legend chipbonus|optionalregex sniffing fromIntelScreen,AgendaView,eventStyles,constantscategory mapping,adaptPlanexternal_id branchCLAUDE.md: drop Saturday-bonus naming rule andEasy / Bonusrow in Fuel TaperUntouched (intentionally)
generateFreeRunand the"free"DayRole— free runs are a distinct concept (no rules, do whatever you want), not optional/bonuslib/demo/fixtures.tshistoricalBonus Easyentries — frozen demo data; with classifiers gone they now render as plain easy eventsTest plan
npx tsc --noEmitcleannpm run lintcleannpm test→ 1427/1427 passingPlanned : X kmandActual : Y km