Repository navigation
fix: keep the MCP hint URL on one line in plain terminals - #805
Open
vschernoff wants to merge 2 commits into
Open
vschernoff wants to merge 2 commits into
vschernoff wants to merge 2 commits into
Conversation
The cosmetic pass in 7b95aa4 placed the paragraph break before the colon rather than after the URL, so any terminal without hyperlink support rendered: ===> 💡 Using an AI coding agent? Lint from it with solhint-mcp : https://www.npmjs.com/package/solhint-mcp leaving the URL on its own line behind an orphaned colon. The hyperlink branch was unaffected, which is why it went unnoticed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line. The cosmetic pass in 7b95aa4 moved the paragraph break in
printMcpHintto before the colon rather than after the URL, so terminals without hyperlink support render:The URL ends up on its own line behind an orphaned colon. After:
The hyperlink branch already had
\n\nin the right place and is unaffected — which is presumably why it went unnoticed, since that's the branch you'd see on a modern terminal.Checked: hyperlink output unchanged, still suppressed in CI and when piped, ESLint and Prettier clean. Added one test asserting the URL stays on the same line as the label, so the same slip can't return quietly.
Separately, and not part of this PR: #802 is still waiting on confirmation that 6.2.5 gets cut from
developrather thanpre-release-625. That branch is missing six commits from develop, including #801 and #800.🤖 Generated with Claude Code