Skip to content

MERGE develop into master 6.2.5 - #808

Merged
dbale-arg merged 31 commits into
masterfrom
develop
Oct 8, 2026
Merged

dbale-arg merged 31 commits into
masterfrom
develop

Conversation

@dbale-arg

Copy link
Copy Markdown
Collaborator

No description provided.

dependabot Bot and others added 30 commits September 3, 2026 00:20
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.4 to 4.28.8.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.28.4...4.28.8)

---
updated-dependencies:
- dependency-name: browserslist
  dependency-version: 4.28.8
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) to 4.3.2 and updates ancestor dependency . These dependencies need to be updated together.


Updates `js-yaml` from 4.3.1 to 4.3.2
- [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.2/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.3.1...4.3.2)

Updates `js-yaml` from 3.14.2 to 3.15.2
- [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.2/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.3.1...4.3.2)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.3.2
  dependency-type: direct:production
- dependency-name: js-yaml
  dependency-version: 3.15.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…rslist-4.28.8

chore(deps-dev): bump browserslist from 4.28.4 to 4.28.8
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 7.1.1 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together.


Updates `serialize-javascript` from 6.0.2 to 7.1.1
- [Release notes](https://github.com/yahoo/serialize-javascript/releases)
- [Commits](yahoo/serialize-javascript@v6.0.2...v7.1.1)

Updates `mocha` from 10.8.2 to 12.0.2
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v10.8.2...v12.0.2)

---
updated-dependencies:
- dependency-name: serialize-javascript
  dependency-version: 7.1.1
  dependency-type: indirect
- dependency-name: mocha
  dependency-version: 12.0.2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.5 to 3.1.8.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.5...v3.1.8)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…ri-3.1.7

chore(deps): bump fast-uri from 3.1.5 to 3.1.8
…51275a1059

chore(deps): bump serialize-javascript and mocha
checkForUpdate() queried the npm registry before every lint run that did not
pass --disc, adding seconds to each invocation. The notice it prints is only
actionable for a person reading a terminal, so the request is wasted whenever
the output is piped or the run happens in CI.

Gate it on the same TTY/CI condition printSuccessPoster already applied,
extracted as isInteractiveTerminal() so both share one definition.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ractive

fix: skip the npm update check outside an interactive terminal
Points people at solhint-mcp, an MCP server that exposes Solhint's linting and
autofix to AI coding agents. Nothing in the CLI currently tells anyone it exists.

  💡 Using an AI coding agent? Lint from it with solhint-mcp

Uses the isInteractiveTerminal helper introduced in #796, so the hint is
suppressed in CI and in piped output. It needs that check: printPoster is called
unguarded from solhint.js when the report has findings, and only
printSuccessPoster tests the terminal.

Deliberately not a client-specific command — the server works with Claude Code,
Codex, Cursor and others, each configured differently. It links to npm, which is
the canonical install source, renders the per-client setup, and does not depend
on a repository's visibility.

Five tests cover the interactive, CI and piped cases, presence in and absence
from the poster, and that no client-specific command appears in the output.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fix: invalidate lint cache when autofix mode changes
feat: show an MCP install hint in the CLI poster
#801 merged into develop on 2026-09-30 and ships in this release. It only touched
lib/cli/terminal-output.js, so it carried no changelog entry of its own.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
checkForUpdate() queried the npm registry before every lint run that did not
pass --disc, adding seconds to each invocation. The notice it prints is only
actionable for a person reading a terminal, so the request is wasted whenever
the output is piped or the run happens in CI.

Gate it on the same TTY/CI condition printSuccessPoster already applied,
extracted as isInteractiveTerminal() so both share one definition.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Points people at solhint-mcp, an MCP server that exposes Solhint's linting and
autofix to AI coding agents. Nothing in the CLI currently tells anyone it exists.

  💡 Using an AI coding agent? Lint from it with solhint-mcp

Uses the isInteractiveTerminal helper introduced in #796, so the hint is
suppressed in CI and in piped output. It needs that check: printPoster is called
unguarded from solhint.js when the report has findings, and only
printSuccessPoster tests the terminal.

Deliberately not a client-specific command — the server works with Claude Code,
Codex, Cursor and others, each configured differently. It links to npm, which is
the canonical install source, renders the per-client setup, and does not depend
on a repository's visibility.

Five tests cover the interactive, CI and piped cases, presence in and absence
from the poster, and that no client-specific command appears in the output.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@vschernoff vschernoff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the release contents are right. Verified at head b1ac43e:

  • 6.2.5 in package.json, docker/Dockerfile and the CHANGELOG heading
  • the CLI hint is present, so it reaches users in this release
  • changelog credits #801, #800 and #796
  • cut from develop, so nothing from #800 or #801 is missing

One cosmetic defect is shipping with it — not a blocker, your call whether to fix before tagging.

On terminals without hyperlink support, printMcpHint renders:

  ===> 💡 Using an AI coding agent? Lint from it with solhint-mcp

: https://www.npmjs.com/package/solhint-mcp

The URL lands on its own line behind a stray colon. The \n\n in 7b95aa4 went before ": ${mcpUrl}" instead of after the URL. The hyperlink branch already has it in the right place and is fine, which is why it is easy to miss on a modern terminal.

One character's placement, in lib/cli/terminal-output.js:

-      : `  ===> 💡 Using an AI coding agent? Lint from it with ${chalk.cyan.bold(label)}\n\n: ${mcpUrl}`,
+      : `  ===> 💡 Using an AI coding agent? Lint from it with ${chalk.cyan.bold(label)}: ${mcpUrl}\n\n`,

This is what #805 was — it was closed as a duplicate of #801, but #801 added the hint and this fixes a bug introduced afterwards. Same function, different change. Happy for it to wait for 6.2.6 if you would rather not touch the release now.

@dbale-arg
dbale-arg merged commit 1748ef3 into master Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants