fix(web): the Credential Sharing page never mentioned team sharing - #123
Merged
Conversation
End-to-end-encrypted team vaults shipped on 2026-07-13, and /docs/credential-sharing documents them in full. The marketing route /credential-sharing is a separate hand-written page, and its copy was never updated -- it listed five providers, omitted the `team` endpoint type, and said nothing about sharing with teammates at all. Anyone evaluating the product from that page concluded teams were unsupported. Add a Team vaults provider card and a team-sharing block covering the trust model (zero-knowledge relay, X25519-sealed DEKs, rotation on departure) with the real `logicsrc teams` commands. The route metadata and llms.txt entry had drifted the same way and also omitted sh1pt. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ralyodio
marked this pull request as ready for review
August 3, 2026 12:06
ralyodio
added a commit
that referenced
this pull request
Aug 3, 2026
…ons (#125) The README's v1.0.0 priorities listed Credential Sharing as covering ".env, Doppler, Railway variables, and GitHub Secrets" -- the same drift just fixed on the marketing page in #123. End-to-end-encrypted team vaults shipped on 2026-07-13 and sh1pt landed as a provider on 07-30, so the highest-traffic surface in the repo still told readers teams did not exist. Separately, packages/cli and plugins/credential-sharing were bumped to 0.1.1 in their package.json without the lockfile following, so it still recorded 0.1.0 for both. Reconciled with `npm install --package-lock-only`; the diff is those two version fields and nothing else. This was cosmetic rather than breaking -- `npm ci` tolerated the mismatch, which is why CI never caught it. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Someone asked whether credential sharing supports teams yet. It has since 2026-07-13 (
f057589), and/docs/credential-sharingdocuments it in full — Team Sharing section, trust model, CLI, rotation.But
/credential-sharingis a different page. It is the legacy marketing SPA route rendered by[[...slug]]/page.tsx→renderPageMarkup(), hand-written copy that was never updated when teams shipped. The live page currently contains zero occurrences of the word "team":It advertised five providers, omitted the
teamendpoint type, and never mentioned sharing with teammates. Anyone evaluating the product from the marketing page — which is the page that ranks and the one linked around — concluded teams were unsupported.This is a copy fix. No behavior, no deploy config, no spec change.
What
team:<team>/<vault>.docs/credential-sharing.md: zero-knowledge relay for values, X25519 public keys, DEK sealed once per member, plaintext and raw DEK never leave the member's machine, grants re-seal rather than reveal, rotation drops departed members. Plus the reallogicsrc login / teams create / push / invite / grant / pullandcredentials rotatecommands.llms.txt— both had drifted the same way and also omittedsh1pt.Verification
vitest run contract— 46 passed. (ontology-api.contract.test.tsfails only until@logicsrc/openontologyis built; unrelated to this change.)next build— clean, all routes generated.Renders
Team vaults,Team sharing, end to end encrypted, andlogicsrc teams create/push/invite/grant/pull.Unrelated
package-lock.jsonversion drift (@logicsrc/cliandplugin-credential-sharingat0.1.1in package.json,0.1.0in the lock) surfaced during install and was reverted to keep this focused — worth a separate fix.🤖 Generated with Claude Code