Skip to content

chore: say teams in the README, and sync the lockfile workspace versions - #125

Merged
ralyodio merged 1 commit into
masterfrom
chore/readme-teams-and-lockfile
Aug 3, 2026
Merged

chore: say teams in the README, and sync the lockfile workspace versions#125
ralyodio merged 1 commit into
masterfrom
chore/readme-teams-and-lockfile

Conversation

@ralyodio

@ralyodio ralyodio commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Two pieces of housekeeping left over from #123 and #124.

README

README.md:119 listed Credential Sharing as covering ".env, Doppler, Railway variables, and GitHub Secrets" — the identical drift #123 just fixed on the marketing page. End-to-end-encrypted team vaults shipped 2026-07-13 and sh1pt landed as a provider 07-30, so the repo's front page still told visitors teams did not exist. Same sentence, now accurate.

Lockfile

packages/cli and plugins/credential-sharing were bumped to 0.1.1 in their package.json without the lockfile following — it still recorded 0.1.0 for both. This surfaced during #123, where I reverted it to keep that PR focused.

Reconciled with npm install --package-lock-only. The entire diff:

-      "version": "0.1.0",
+      "version": "0.1.1",
-      "version": "0.1.0",
+      "version": "0.1.1",

No dependency churn.

Worth being clear that this was cosmetic, not breaking: npm ci tolerated the mismatch, which is why CI stayed green through it. It is hygiene so the lock tells the truth about what is in the tree, not a fix for a live failure.

Verification

  • npm ci — exit 0 against the reconciled lock, and it does not re-modify the lockfile afterward.
  • No source changes, so behavior is unaffected.

🤖 Generated with Claude Code

The README's v1.0.0 priorities listed Credential Sharing as covering
".env, Doppler, Railway variables, and GitHub Secrets" -- the same drift
just fixed on the marketing page in #123. End-to-end-encrypted team
vaults shipped on 2026-07-13 and sh1pt landed as a provider on 07-30,
so the highest-traffic surface in the repo still told readers teams did
not exist.

Separately, packages/cli and plugins/credential-sharing were bumped to
0.1.1 in their package.json without the lockfile following, so it still
recorded 0.1.0 for both. Reconciled with `npm install
--package-lock-only`; the diff is those two version fields and nothing
else. This was cosmetic rather than breaking -- `npm ci` tolerated the
mismatch, which is why CI never caught it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

vu1nz Security Review

0 finding(s) in PR #?

No security issues found.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

ThreatCrush Security Scan

55 finding(s)

HIGH/CRITICAL: 30 | MEDIUM: 25

Severity Rule Location
HIGH secret-openai-key plugins/credential-sharing/src/vault-encryption.test.ts:21
HIGH manifest-typosquat apps/commandboard-web/package.json:20
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:392
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:410
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:426
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:428
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:433
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:471
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:477
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:499
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:516
HIGH secret-generic-credential apps/logicsrc-web/contract/logicsrc-web.contract.test.ts:528
HIGH manifest-typosquat apps/logicsrc-web/package.json:27
HIGH js-ssrf-outbound-request apps/logicsrc-web/src/lib/coinpay.ts:50
HIGH manifest-typosquat apps/pwa/package.json:19
HIGH js-ssrf-outbound-request apps/pwa/public/sw.js:45
HIGH secret-generic-credential apps/pwa/test/appbar.test.mjs:10
HIGH secret-generic-credential packages/account-core/src/index.test.ts:104
HIGH secret-generic-credential packages/agentad/src/exchange.test.ts:13
HIGH secret-generic-credential plugins/agentgit/src/index.ts:12
HIGH secret-generic-credential plugins/c0mpute/src/index.ts:12
HIGH secret-generic-credential plugins/coinpay/src/index.ts:12
HIGH secret-generic-credential plugins/credential-sharing/src/engine.test.ts:69
HIGH secret-generic-credential plugins/credential-sharing/src/engine.test.ts:134
HIGH secret-database-url plugins/credential-sharing/src/rekey.test.ts:33
HIGH secret-generic-credential plugins/credential-sharing/src/vault-encryption.test.ts:21
HIGH js-ssrf-outbound-request plugins/feed-discovery/src/providers/itunes-podcast.ts:37
HIGH js-ssrf-outbound-request plugins/feed-discovery/src/providers/podcastindex.ts:43
HIGH secret-generic-credential plugins/sh1pt/src/index.ts:11
HIGH secret-generic-credential plugins/ugig/src/index.ts:11
MEDIUM js-unescaped-html-sink apps/commandboard-web/src/main.ts:19
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/app/[[...slug]]/page.tsx:73
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/app/blog/[slug]/page.tsx:120
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/app/docs/[slug]/page.tsx:55
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/app/layout.tsx:83
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/app/pricing/page.tsx:46
MEDIUM js-unescaped-html-sink apps/logicsrc-web/src/components/site-shell.tsx:46
MEDIUM sql-template-interpolation packages/cli/src/index.ts:812
MEDIUM sql-template-interpolation packages/cli/src/index.ts:814
MEDIUM sql-template-interpolation packages/cli/src/index.ts:821
MEDIUM sql-template-interpolation packages/cli/src/teams.ts:284
MEDIUM redos-nested-quantifier packages/openontology/src/ids.ts:20
MEDIUM redos-nested-quantifier packages/openprd/src/validate.ts:41
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-account-audit-event.schema.json:23
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-account-grant.schema.json:23
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-account-grant.schema.json:35
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-account-provider.schema.json:20
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-connected-account.schema.json:30
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-credential-audit-event.schema.json:14
MEDIUM redos-nested-quantifier packages/schemas/schemas/logicsrc-openontology-manifest.schema.json:28

…and 5 more. Full results in the Security tab.

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio marked this pull request as ready for review August 3, 2026 13:56
@ralyodio
ralyodio merged commit 3440a2e into master Aug 3, 2026
7 checks passed
@ralyodio
ralyodio deleted the chore/readme-teams-and-lockfile branch August 3, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant