test(payments): the country agreement check iterates the module, not a copied list - #236
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The country agreement check iterates the module, not a copied list
A one-line export plus a loop change, and a measured reason.
connectCountryForCurrencydecides whether we may mint (currency -> country);CONNECT_ONBOARDABLE_COUNTRIESdecides whether that country is accepted at the request boundary. Theagreement test between them existed already — but it iterated a literal
["CHF","GBP","USD","AED"], athird hand-maintained copy of the same knowledge.
The failure it was blind to
Add a currency to
UNAMBIGUOUSwhose country the boundary refuses. The mint then throws insidecreateExpressAccount,mintForProposalcatches it (by design — it must never throw, its caller chain endsat the Mollie webhook), and the result is a restaurant that bought online payments, got a tenant without
the module, and a note in a PR body nobody reads twice. No crash. No red test.
Measured, with the same mutant on both sides
NOK: "NO"added to the map (NOis not onboardable;NOKis referenced nowhere else, so nothing catchesit incidentally):
NOK resolves to NO, which the request boundary would refuseMutant verified landed (
grep -F) and compiled (tscexit 0) before either result was read, and revertedafter — tree clean, 6 passing,
tsc0.(A first attempt used
SEK, which the file already uses as its "unknown currency" example, so that testfailed for an unrelated reason and proved nothing about the agreement assertion. The currency was changed
until the mutant isolated the property under test.)
Also added
A positive control on the loop: if
RESOLVABLE_CURRENCIESwere ever emptied, every assertion inside it wouldbe skipped and the file would still be green. That assertion is what dies then.
Same defect shape as #225 (a quote and a charge computed independently) and #224 (a crossover sentence
written twice): assert that two sides agree, never that one equals a remembered value.
No behaviour change.
RESOLVABLE_CURRENCIESis derived from the existing map.