release: the country agreement check iterates the module, not a copied list - #237
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Release — the country agreement check iterates the module, not a copied list
One commit (#236). Test + a one-line export. No behaviour change.
connectCountryForCurrencydecides whether we may mint (currency -> country);CONNECT_ONBOARDABLE_COUNTRIESdecides whether the request boundary accepts that country. The agreement test between them existed, but it
iterated a literal
["CHF","GBP","USD","AED"]— a third hand-maintained copy of the same knowledge.The silent failure it was blind to
Add a currency whose country the boundary refuses: the mint throws inside
createExpressAccount,mintForProposalcatches it (by design — it must never throw, its caller chain ends at the Mollie webhook),and the outcome is a restaurant that bought online payments and got a tenant without the module, plus a
note in a PR body nobody reads twice. No crash. No red test.
Measured, same mutant both sides
NOK: "NO"added to the map (NOis not onboardable;NOKis referenced nowhere else, so nothing catches itincidentally):
NOK resolves to NO, which the request boundary would refuseMutant verified landed (
grep -F) and compiled (tsc0) before either result was read, then reverted.A first attempt used
SEK, which the file already uses as its "unknown currency" example — it went red for anunrelated reason and proved nothing. A red result only counts when it fails because of the property under test.
Also adds a positive control: if
RESOLVABLE_CURRENCIESwere emptied, every assertion in the loop would beskipped and the file would still be green. That assertion is what dies then.