Added some safety interlocks and added the Powersupply tab in GUI#2
Open
Sayan-Dhani wants to merge 3 commits into
Open
Added some safety interlocks and added the Powersupply tab in GUI#2Sayan-Dhani wants to merge 3 commits into
Sayan-Dhani wants to merge 3 commits into
Conversation
arizzi
reviewed
May 28, 2026
| try: | ||
| if "marta" not in system_status: | ||
| return False | ||
| fsm_state = system_status["marta"].get("fsm_state", "") |
Contributor
There was a problem hiding this comment.
need to check OT open and not just pixel!
arizzi
reviewed
May 28, 2026
|
|
||
| log_msg = f"Soft interlock: LV_on={lv_on}, MARTA_OT={marta_ot}, MARTA_IT={marta_it}" | ||
|
|
||
| if lv_on and not marta_on: |
Contributor
There was a problem hiding this comment.
the whole point of checking differently IT vs OT is that one should only allow LV on when MARTA OT is on... why you make the OR again?!?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.