Add SILK floating-point LPC primitives#154
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 88.19% 88.28% +0.09%
==========================================
Files 34 35 +1
Lines 7868 7932 +64
==========================================
+ Hits 6939 7003 +64
Misses 703 703
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thomas-vilte
force-pushed
the
feat/silk-lpc-float
branch
from
July 19, 2026 17:59
4787443 to
7fa92ea
Compare
thomas-vilte
changed the title
maxLPCOrder was 16 with a comment claiming it matched libopus's SILK_MAX_ORDER_LPC, but that constant is actually 24 — harmless today since this port only requests order 10/16, but a latent trap if a future hybrid/SWB sub-PR reuses schurFLP at a higher order. Also covers the correlationCount > inputDataSize clamp in autocorrelationFLP, untested before (75% coverage on that function) — without it, the lag loop slices inputData past its end once the requested count exceeds what's available. Co-authored-by: François Allais <francois.allais@hotmail.com>
FrantaBOT
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
lpc_float.go, the shared floating-point DSP toolkit ported fromsilk/float/*_FLP.c— autocorrelation, Schur recursion, reflection-to-LPC conversion, bandwidth expansion, sine windowing, and the LPC analysis filter. Nothing in this repo calls these yet; they're the primitives the pitch analysis and Burg/LPC sub-PRs build on next.Ported:
innerProductFLP,autocorrelationFLP,schurFLP,k2aFLP,bwexpanderFLP,applySineWindowFLP,lpcAnalysisFilterFLP.Reference issue
Part of the SILK encoder series (#147).