Add SILK float pitch/resampler primitives#156
Open
thomas-vilte wants to merge 2 commits into
Open
Conversation
Co-authored-by: François Allais <francois.allais@hotmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 88.49% 88.58% +0.09%
==========================================
Files 36 37 +1
Lines 8074 8141 +67
==========================================
+ Hits 7145 7212 +67
Misses 703 703
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FrantaBOT
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds the last few shared floating-point primitives used by the pitch analysis stage:
resamplerDown2(2:1 decimator),float2ShortArray/short2FloatArray,energyFLP,pitchXcorr, and the two insertion sort helpers (insertionSortDecreasingFLP/insertionSortIncreasing). these sit alongside the LPC float primitives from #154 — same "shared DSP building blocks" piece of the split, just the half that didn't make it into that PRported from
resampler_down2.c(coefficients cross-checked againstresampler_rom.h), the float/short conversion inlines inSigProc_FLP.h,energy_FLP.c, andsort_FLP.c/sort.cone thing worth flagging:
pitchXcorrhere is a plain loop overinnerProductFLP, not libopus's SIMD-optimizedcelt_pitch_xcorr. Same result, just without the vectorized fast path — fine for a shared primitive, the actual pitch-analysis algorithm that calls it is a separate, later piece of this splitReference issue
part of the SILK encoder series (#154)