[codex] Fix marketing download fallback links#1747
[codex] Fix marketing download fallback links#1747juliusmarminge merged 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Simple marketing page fix replacing broken "#" href fallback links with the GitHub releases URL - a pattern already used elsewhere in the codebase. No runtime behavior impact beyond improving UX when JavaScript is unavailable. You can customize Macroscope's approvability policy. Learn more. |
…g-download-links Merge upstream pingdotgg#1747: Fix marketing download fallback links
Summary
#Why
The download cards were initially rendered with
href="#", so an early click or a no-JS/failing-JS load produced a broken link even though the page already had a valid releases fallback.Impact
Users always land on a valid download surface, and still get direct binary links when the release fetch succeeds.
Validation
bun fmtbun lintbun typecheck(fails in pre-existing unrelatedpackages/sharedfiles:DrainableWorker.tsandKeyedCoalescingWorker.ts)Note
Fix fallback download links on the marketing download page
Replaces non-functional
href="#"placeholders withRELEASES_URLon all four platform download links (macOS arm64, macOS x64, Windows x64, Linux x86_64) in download.astro.Macroscope summarized aa2c25d.
Note
Low Risk
Low risk UI-only change that updates initial
hreftargets on the marketing download page; no backend, auth, or data model changes.Overview
Updates the marketing
download.astropage so the platform download cards no longer render withhref="#", instead defaulting toRELEASES_URL(GitHub releases) as a reliable fallback.The existing client-side release lookup still upgrades cards to direct asset URLs when available, but users who click early or have JS disabled will now land on a valid download surface.
Reviewed by Cursor Bugbot for commit aa2c25d. Bugbot is set up for automated code reviews on this repo. Configure here.