Skip to content

[codex] Fix marketing download fallback links#1747

Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom
sabraman:codex/marketing-download-fallback-links
Apr 5, 2026
Merged

[codex] Fix marketing download fallback links#1747
juliusmarminge merged 2 commits intopingdotgg:mainfrom
sabraman:codex/marketing-download-fallback-links

Conversation

@sabraman
Copy link
Copy Markdown
Contributor

@sabraman sabraman commented Apr 5, 2026

Summary

  • default the marketing download cards to the GitHub releases page instead of #
  • keep the existing client-side release lookup so the cards are still upgraded to direct asset links when release data loads

Why

The download cards were initially rendered with href="#", so an early click or a no-JS/failing-JS load produced a broken link even though the page already had a valid releases fallback.

Impact

Users always land on a valid download surface, and still get direct binary links when the release fetch succeeds.

Validation

  • bun fmt
  • bun lint
  • bun typecheck (fails in pre-existing unrelated packages/shared files: DrainableWorker.ts and KeyedCoalescingWorker.ts)

Note

Fix fallback download links on the marketing download page

Replaces non-functional href="#" placeholders with RELEASES_URL on all four platform download links (macOS arm64, macOS x64, Windows x64, Linux x86_64) in download.astro.

Macroscope summarized aa2c25d.


Note

Low Risk
Low risk UI-only change that updates initial href targets on the marketing download page; no backend, auth, or data model changes.

Overview
Updates the marketing download.astro page so the platform download cards no longer render with href="#", instead defaulting to RELEASES_URL (GitHub releases) as a reliable fallback.

The existing client-side release lookup still upgrades cards to direct asset URLs when available, but users who click early or have JS disabled will now land on a valid download surface.

Reviewed by Cursor Bugbot for commit aa2c25d. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 06f31694-9a23-4b36-8d8d-0d4694e67284

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 5, 2026
@sabraman sabraman marked this pull request as ready for review April 5, 2026 00:16
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 5, 2026

Approvability

Verdict: Approved

Simple marketing page fix replacing broken "#" href fallback links with the GitHub releases URL - a pattern already used elsewhere in the codebase. No runtime behavior impact beyond improving UX when JavaScript is unavailable.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 1234708 into pingdotgg:main Apr 5, 2026
15 of 17 checks passed
aaditagrawal pushed a commit to aaditagrawal/t3code that referenced this pull request Apr 5, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 5, 2026
…g-download-links

Merge upstream pingdotgg#1747: Fix marketing download fallback links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants