Skip to content

Merge upstream #1747: Fix marketing download fallback links#52

Merged
aaditagrawal merged 1 commit intomainfrom
merge/upstream-1747-marketing-download-links
Apr 5, 2026
Merged

Merge upstream #1747: Fix marketing download fallback links#52
aaditagrawal merged 1 commit intomainfrom
merge/upstream-1747-marketing-download-links

Conversation

@aaditagrawal
Copy link
Copy Markdown
Owner

@aaditagrawal aaditagrawal commented Apr 5, 2026

Summary

Cherry-picks upstream commit 12347082 u2014 "[codex] Fix marketing download fallback links (pingdotgg#1747)".

Changes

  • Replaces dead href="#" fallback links on the marketing download page with href={RELEASES_URL} so download buttons point to the GitHub releases page when JavaScript has not yet resolved the specific asset URL.

Conflict Resolution

None u2014 clean cherry-pick. The fork has no modifications to this marketing page.

Verification

  • bun typecheck u2705
  • bun fmt u2705
  • bun lint u2705

Fork Preservation

No fork-specific code affected (isolated marketing page fix).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed download links for all supported platforms (macOS arm64/x64, Windows x64, and Linux x86_64) to properly direct users to the releases page instead of remaining non-functional.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 701fee61-0b37-4114-b6f1-cb1b5707cf69

📥 Commits

Reviewing files that changed from the base of the PR and between 0196390 and 0cb66d6.

📒 Files selected for processing (1)
  • apps/marketing/src/pages/download.astro

📝 Walkthrough

Walkthrough

Updated download card links in the download page component from non-functional placeholder # values to use a real RELEASES_URL import across all platform-specific download cards (macOS arm64/x64, Windows x64, Linux x86_64), maintaining existing client-side fallback logic.

Changes

Cohort / File(s) Summary
Download Page Links
apps/marketing/src/pages/download.astro
Added RELEASES_URL import and replaced all download card href="#" placeholder values with href={RELEASES_URL} for macOS, Windows, and Linux download options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

size:S

Poem

🐰 Hop, hop, links now lead the way,
No more placeholders in the fray,
RELEASES_URL brings downloads true,
From dream to deed—a small hop, but brand new!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Merge upstream #1747: Fix marketing download fallback links' accurately describes the main change—fixing marketing download fallback links by cherry-picking upstream commit.
Description check ✅ Passed The PR description is comprehensive, explaining what changed, why it changed, conflicts, and verification steps, though it deviates from the repository's template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch merge/upstream-1747-marketing-download-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 effective changed lines (test files excluded in mixed PRs). labels Apr 5, 2026
@aaditagrawal aaditagrawal merged commit 7cd1d60 into main Apr 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants