Repository navigation
Stop type errors from reaching production, and run tests and build in CI - #85
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
|
Read the pnpm version from packageManager instead of repeating it, drop the unused dummy build env, use a read-only token, and run once per PR commit with stale runs cancelled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo @greptileai review Please review the latest head, cfa7e2f. It reads the pnpm version from |
Type errors could ship to production.
next.config.jssettypescript.ignoreBuildErrors, so Vercel deployed builds with type errors. This happened with #79. Its merge commit failed the CI typecheck (headers().geton a Promise), but Vercel deployed it to production and/embedbroke. Also, CI did not run the tests or the production build.Vercel production builds now fail on type errors. This PR removes
ignoreBuildErrors, sonext buildruns the TypeScript check. If a build fails, Vercel does not deploy it and the last good deploy stays live.CI changes:
pnpm testandpnpm buildafter typecheck and lint. The build needs no env vars.pnpm/action-setup, which reads the version frompackageManager. The pnpm version does not change: the oldnpm install -g pnpmalso ran 8.15.9, because pnpm switches to thepackageManagerversion.--frozen-lockfileexplicit.CI=truealready froze the lockfile, so this does not change behavior.contents: read). The repo default is write.mainand on PRs. Before, every PR commit ran CI two times (push and pull_request). A new push cancels the older run for the same ref.Checks:
pnpm buildwith the type check on.Created with GPT-6 Astra in Codex. Takeover fixes by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code