Skip to content

Stop type errors from reaching production, and run tests and build in CI - #85

Merged
t3dotgg merged 2 commits into
mainfrom
t3code/verify-build-in-ci
Sep 25, 2026
Merged

t3dotgg merged 2 commits into
mainfrom
t3code/verify-build-in-ci

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Type errors could ship to production. next.config.js set typescript.ignoreBuildErrors, so Vercel deployed builds with type errors. This happened with #79. Its merge commit failed the CI typecheck (headers().get on a Promise), but Vercel deployed it to production and /embed broke. Also, CI did not run the tests or the production build.

Vercel production builds now fail on type errors. This PR removes ignoreBuildErrors, so next build runs the TypeScript check. If a build fails, Vercel does not deploy it and the last good deploy stays live.

CI changes:

  • Runs pnpm test and pnpm build after typecheck and lint. The build needs no env vars.
  • Pins Node 24. Before, CI used the runner's default Node.
  • Sets up pnpm with pnpm/action-setup, which reads the version from packageManager. The pnpm version does not change: the old npm install -g pnpm also ran 8.15.9, because pnpm switches to the packageManager version.
  • Keeps --frozen-lockfile explicit. CI=true already froze the lockfile, so this does not change behavior.
  • Uses a read-only token (contents: read). The repo default is write.
  • Runs on pushes to main and on PRs. Before, every PR commit ran CI two times (push and pull_request). A new push cancels the older run for the same ref.

Checks:

  • Ran the CI steps locally with an empty env: typecheck, lint, test (31 passed), and build all pass.
  • The open PRs #81, #82, #83, #84, and #86 each merge cleanly with this branch and pass pnpm build with the type check on.

Created with GPT-6 Astra in Codex. Takeover fixes by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
markerthing Ready Ready Preview Sep 25, 2026 4:11am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7e285c72-7617-47de-b05b-24455f008d81

📥 Commits

Reviewing files that changed from the base of the PR and between 688e1e4 and cfa7e2f.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml
  • next.config.js

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Build setup now enforces type safety and runs tests in CI.

The PR appears safe to merge based on the reviewed changes.

Reviews (2) · Last reviewed commit: "Tighten CI triggers, permissions, and pn..."

Comment thread .github/workflows/ci.yaml
Read the pnpm version from packageManager instead of repeating it, drop
the unused dummy build env, use a read-only token, and run once per PR
commit with stale runs cancelled.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@t3dotgg t3dotgg changed the title Run tests and production build in CI Stop type errors from reaching production, and run tests and build in CI Sep 25, 2026
@t3dotgg

t3dotgg commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

@greptileai review

Please review the latest head, cfa7e2f. It reads the pnpm version from packageManager, removes the dummy build env, sets a read-only token, and runs CI once per PR commit.

@t3dotgg
t3dotgg merged commit ac74d01 into main Sep 25, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — cfa7e2fc Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant