Add AGENTS.md and stop stale route types from failing typecheck - #87
Conversation
next dev wrote AGENTS.md and CLAUDE.md into every checkout that lacked its agent-rules block. AGENTS.md now holds project facts plus that block, so next dev leaves it alone. Screenshot fixture routes go in the gitignored src/app/fixtures/. pnpm typecheck now deletes .next/dev/types and runs next typegen, so a deleted route no longer fails it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. WalkthroughThe pull request adds repository guidance, excludes temporary screenshot routes from Git, and updates the typecheck script to generate Next.js types before running TypeScript checks. ChangesRepository workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The typecheck command clears stale development types and regenerates production route types. No merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo @greptileai review |
Agents on this repo kept hitting two problems:
next devwritesAGENTS.mdandCLAUDE.mdinto any checkout that does not have its agent-rules block. These files showed up as stray changes in agent worktrees..next/dev/typesafter you delete it. Thenpnpm typecheckfails withCannot find module '.../page.js'. This caused false failures two times.Fix
AGENTS.mdwith project facts: where marker logic and tests go, the pnpm pin, env setup, fixture routes, and PR rules. It includes the exact block that Next 16.3.6 writes, sonext devleaves the file alone.CLAUDE.mdonly imports@AGENTS.md.src/app/fixtures/<name>/page.tsx. That folder is gitignored, so a fixture cannot deploy.pnpm typecheckis nowrm -rf .next/dev/types && next typegen && tsc --noEmit. It rebuilds route types from the current routes before it checks.The CI part of the original task was already done in #85, so
ci.yamldoes not change here.Checks
next devwith an agent detected. It did not changeAGENTS.mdor create other files.next dev, and deleted the route. Baretscthen fails, andpnpm typecheckpasses.pnpm buildis not affected by stale dev types.pnpm typecheck,pnpm lint,pnpm test(38 passed), andpnpm buildpass locally.Made by Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code
Summary by CodeRabbit