Skip to content

replay: support audit log plugin v2 format (#1057)#1163

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:feature/replay-filter-tablesfrom
ti-chi-bot:cherry-pick-1057-to-feature/replay-filter-tables
May 28, 2026
Merged

replay: support audit log plugin v2 format (#1057)#1163
ti-chi-bot[bot] merged 5 commits into
pingcap:feature/replay-filter-tablesfrom
ti-chi-bot:cherry-pick-1057-to-feature/replay-filter-tables

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1057

What problem does this PR solve?

Issue Number: close #1056

Problem Summary:

What is changed and how it works:

Implement a basic support for audit log extension.

The current implementation (based on current extension format) has the following known issues:

  1. All parameters are parsed as string.
  2. Empty string parameters cannot be parsed correctly.
  3. Only end time is stored in the extension format.
  4. If there is a comma in the string parameter, the result will not be correct.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added the lgtm label May 28, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 28, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-28 04:07:20.778136667 +0000 UTC m=+497910.748301728: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot Bot added the approved label May 28, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.39474% with 90 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/replay-filter-tables@8c827ab). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/cmd/audit_log_extension.go 74.34% 53 Missing and 16 partials ⚠️
pkg/sqlreplay/replay/replay.go 20.00% 9 Missing and 3 partials ⚠️
pkg/sqlreplay/cmd/cmd.go 12.50% 7 Missing ⚠️
cmd/replayer/main.go 0.00% 1 Missing ⚠️
pkg/sqlreplay/store/rotate.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             feature/replay-filter-tables    #1163   +/-   ##
===============================================================
  Coverage                                ?   67.17%           
===============================================================
  Files                                   ?      155           
  Lines                                   ?    16959           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    11392           
  Misses                                  ?     4785           
  Partials                                ?      782           
Flag Coverage Δ
unit 67.17% <70.39%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot Bot merged commit 643fb3d into pingcap:feature/replay-filter-tables May 28, 2026
6 checks passed
@djshow832 djshow832 deleted the cherry-pick-1057-to-feature/replay-filter-tables branch May 28, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants