Skip to content

replay: support audit log plugin v2 format#1057

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:mainfrom
YangKeao:impl-1056
May 27, 2026
Merged

replay: support audit log plugin v2 format#1057
ti-chi-bot[bot] merged 2 commits into
pingcap:mainfrom
YangKeao:impl-1056

Conversation

@YangKeao
Copy link
Copy Markdown
Member

@YangKeao YangKeao commented Jan 8, 2026

What problem does this PR solve?

Issue Number: close #1056

Problem Summary:

What is changed and how it works:

Implement a basic support for audit log extension.

The current implementation (based on current extension format) has the following known issues:

  1. All parameters are parsed as string.
  2. Empty string parameters cannot be parsed correctly.
  3. Only end time is stored in the extension format.
  4. If there is a comma in the string parameter, the result will not be correct.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 75.08772% with 71 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8306850). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/cmd/audit_log_extension.go 80.00% 35 Missing and 15 partials ⚠️
pkg/sqlreplay/replay/replay.go 20.00% 9 Missing and 3 partials ⚠️
pkg/sqlreplay/cmd/cmd.go 12.50% 7 Missing ⚠️
cmd/replayer/main.go 0.00% 1 Missing ⚠️
pkg/sqlreplay/store/rotate.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage        ?   67.55%           
=======================================
  Files           ?      150           
  Lines           ?    16660           
  Branches        ?        0           
=======================================
  Hits            ?    11255           
  Misses          ?     4643           
  Partials        ?      762           
Flag Coverage Δ
unit 67.55% <75.08%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YangKeao YangKeao marked this pull request as ready for review May 27, 2026 14:19
@ti-chi-bot ti-chi-bot Bot added the lgtm label May 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-27 14:29:59.920789319 +0000 UTC m=+448869.890954377: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot Bot added the approved label May 27, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 3ff34f5 into pingcap:main May 27, 2026
6 checks passed
@djshow832
Copy link
Copy Markdown
Collaborator

/cherry-pick feature/replay-filter-tables

@ti-chi-bot
Copy link
Copy Markdown
Member

@djshow832: new pull request created to branch feature/replay-filter-tables: #1163.

Details

In response to this:

/cherry-pick feature/replay-filter-tables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support audit log extension format for replayer

4 participants