Skip to content

PPLT-6244: Fix CDP resize on Ruby 3; exact responsive widths and closed shadow roots #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaghavsBrowserStack wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PPLT-6244: Fix CDP resize on Ruby 3; exact responsive widths and closed shadow roots #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e320d
PPLT-6244: Pass CDP params as keyword arguments so Chrome resize work…
RaghavsBrowserStack Oct 19, 2026
81ac592
PPLT-6244: Exact responsive widths on Edge/Firefox and capture closed…
RaghavsBrowserStack Oct 27, 2026
d20326f
PPLT-6244: Keep the viewport override undoable when reading innerWidt…
RaghavsBrowserStack Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@ jobs:
matrix:
os: [ubuntu-latest]
ruby: ['2.6', '2.7']
selenium: ['']
include:
- os: ubuntu-latest
ruby: '3.3'
selenium: '4.50.0'

@RaghavsBrowserStack RaghavsBrowserStack Oct 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Low] Only Ruby 3 leg pins Selenium 4.50.0

4.51.0 is already published, and the pin will fall behind.

Suggestion: Add a Ruby 3 leg with selenium: '' (latest), or bump the pin regularly.

Reviewer: stack-percy-web-sdks-code-reviewer

runs-on: ${{ matrix.os }}
env:
SELENIUM_VERSION: ${{ matrix.selenium }}
steps:
- uses: actions-ecosystem/action-regex-match@v2
id: regex-match
Expand All @@ -35,8 +42,8 @@ jobs:
- uses: actions/cache@v3
with:
path: "./vendor/bundle"
key: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/${{ hashFiles('**/Gemfile.lock') }}
restore-keys: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/
key: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}-selenium-${{ matrix.selenium }}/${{ hashFiles('**/Gemfile.lock') }}
restore-keys: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}-selenium-${{ matrix.selenium }}/
- uses: actions/setup-node@v3
with:
node-version: 16
Expand Down
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ source "https://rubygems.org"
# Specify your gem's dependencies in percy-selenium.gemspec
gemspec

# Lets CI certify a specific Selenium release (e.g. SELENIUM_VERSION=4.50.0).
selenium_version = ENV.fetch("SELENIUM_VERSION", "")
gem "selenium-webdriver", selenium_version unless selenium_version.empty?

gem "guard-rspec", require: false

group :test, :development do
Expand Down
Loading
Loading